From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 4/4] block: move plug rq alloc into helper and ensure queue match
Date: Thu, 4 Nov 2021 11:37:12 -0600 [thread overview]
Message-ID: <dfe03d35-dce5-4ecb-e9bd-4cc38e318b1d@kernel.dk> (raw)
In-Reply-To: <YYQZYfI/rmH5RshU@infradead.org>
On 11/4/21 11:33 AM, Christoph Hellwig wrote:
> On Thu, Nov 04, 2021 at 05:35:10AM -0600, Jens Axboe wrote:
>> I tend to prefer having logic flow from the expected conditions. And
>> since we need to check if the plug is valid anyway, I prefer the current
>> logic.
>
> Well, for 99% of the I/O not using a cached request is the expected
> condition.
That may very well be the case right now, but as more things plug into
propagating expected number of requests, that's likely to change.
That said, I did reflow it for you in the updated version.
--
Jens Axboe
prev parent reply other threads:[~2021-11-04 17:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:32 [PATCHSET 0/4] Alloc batch fixes Jens Axboe
2021-11-03 18:32 ` [PATCH 1/4] block: have plug stored requests hold references to the queue Jens Axboe
2021-11-04 9:01 ` Christoph Hellwig
2021-11-04 11:33 ` Jens Axboe
2021-11-03 18:32 ` [PATCH 2/4] block: make blk_try_enter_queue() available for blk-mq Jens Axboe
2021-11-03 18:32 ` [PATCH 3/4] block: move queue enter logic into blk_mq_submit_bio() Jens Axboe
2021-11-04 9:10 ` Christoph Hellwig
2021-11-04 11:41 ` Jens Axboe
2021-11-04 12:14 ` Jens Axboe
2021-11-04 17:32 ` Christoph Hellwig
2021-11-04 17:35 ` Jens Axboe
2021-11-04 17:30 ` Christoph Hellwig
2021-11-04 17:36 ` Jens Axboe
2021-11-03 18:32 ` [PATCH 4/4] block: move plug rq alloc into helper and ensure queue match Jens Axboe
2021-11-04 9:17 ` Christoph Hellwig
2021-11-04 11:35 ` Jens Axboe
2021-11-04 17:33 ` Christoph Hellwig
2021-11-04 17:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe03d35-dce5-4ecb-e9bd-4cc38e318b1d@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).