From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Cc: sagi@grimberg.me, song@kernel.org, linux-block@vger.kernel.org,
linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: remove support or stream based temperature hint
Date: Fri, 4 Mar 2022 12:38:04 -0700 [thread overview]
Message-ID: <e04da66f-3f72-5d8a-479b-f413222c3646@kernel.dk> (raw)
In-Reply-To: <20220304193600.GA15474@lst.de>
On 3/4/22 12:36 PM, Christoph Hellwig wrote:
> On Fri, Mar 04, 2022 at 11:34:39AM -0800, Keith Busch wrote:
>> On Fri, Mar 04, 2022 at 06:55:55PM +0100, Christoph Hellwig wrote:
>>> - ctrl->nssa = le16_to_cpu(s.nssa);
>>> - if (ctrl->nssa < BLK_MAX_WRITE_HINTS - 1) {
>>> - dev_info(ctrl->device, "too few streams (%u) available\n",
>>> - ctrl->nssa);
>>> - goto out_disable_stream;
>>> - }
>>
>> Just fyi, looks like the patch was built against an older version of the
>> driver, so it doesn't apply cleanly to nvme-5.18 at the above part.
>>
>> Also please consider folding the following in this patch since it removes all
>> nr_streams use:
>
> This was against Jens' for-5.18/block tree. I'm a bit lost what tree
> to best send it against as there will always be some conflicts.
It's always a bit of a problem when patches touch both drivers and core.
I actually put this one in a special branch just because of that. I'll
fold in Keith's incremental.
--
Jens Axboe
next prev parent reply other threads:[~2022-03-04 20:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 17:55 [PATCH 1/2] nvme: remove support or stream based temperature hint Christoph Hellwig
2022-03-04 17:55 ` [PATCH 2/2] block: remove the per-bio/request write hint Christoph Hellwig
2022-03-04 19:24 ` Jens Axboe
2022-03-04 22:12 ` Dave Chinner
2022-03-05 5:19 ` Christoph Hellwig
2022-03-05 21:40 ` Dave Chinner
2022-03-05 23:55 ` Bart Van Assche
2022-03-06 17:11 ` Jens Axboe
2022-03-06 18:01 ` Christoph Hellwig
2022-03-06 18:06 ` Jens Axboe
2022-03-06 23:17 ` Dave Chinner
2022-03-09 13:31 ` Manjong Lee
2022-03-09 8:24 ` Paul Menzel
2022-03-10 11:34 ` [EXT] " Luca Porzio (lporzio)
2022-03-10 12:15 ` Jens Axboe
2022-03-10 18:50 ` Luca Porzio (lporzio)
2022-03-10 19:10 ` Jens Axboe
2022-03-10 19:34 ` Bart Van Assche
2022-03-10 21:52 ` Bean Huo (beanhuo)
2022-03-10 22:10 ` Jens Axboe
2022-03-11 16:45 ` Bart Van Assche
2022-03-11 16:56 ` Jens Axboe
2022-03-14 7:40 ` Avi Shchislowski
2022-03-14 8:00 ` hch
2022-03-14 19:50 ` Eric Biggers
2022-03-14 19:58 ` [EXT] " Jens Axboe
2022-03-15 15:36 ` Luca Porzio (lporzio)
2022-03-15 15:44 ` Jens Axboe
2022-03-10 22:18 ` Bart Van Assche
2022-03-11 5:31 ` Eric Biggers
2022-03-11 9:21 ` Luca Porzio (lporzio)
2022-03-10 14:21 ` hch
2022-03-10 18:51 ` Luca Porzio (lporzio)
2022-03-10 19:14 ` hch
2022-03-11 5:06 ` Eric Biggers
2022-03-11 9:23 ` Luca Porzio (lporzio)
2022-03-04 19:34 ` [PATCH 1/2] nvme: remove support or stream based temperature hint Keith Busch
2022-03-04 19:36 ` Christoph Hellwig
2022-03-04 19:38 ` Jens Axboe [this message]
2022-03-04 20:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04da66f-3f72-5d8a-479b-f413222c3646@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).