From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 917FC23D2B9 for ; Mon, 14 Apr 2025 14:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744642076; cv=none; b=Z853q24E6hLGRjABhKoo+L81jYRk5DPedU0SbwG5q+f84wdbdmmVin3uCYmrPRT2zCP3gnRhqOe4JiVggidGfGBAOMjgqCEVIeA4oE21uaaED0Q9b7JbKMYwxf1oQeC+xjYv4ef6wgQtNV9xb8eJDyRBPsiH2iyoVscMlbfmO7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744642076; c=relaxed/simple; bh=8Qtn8KlEQvxgVdPrvGuh4Sfq5tYrSo6Kof/1qWPEE88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y//tlosOr5G6SUsRYDz2vVpNm5QL8wkh/oSmcz9xSfrbVDe1E/35VMt9317Ck84d0b3ATsw5c3Ehz0/pOmXjFk1yojKZrbVHRuhuuv3axZsas5XJ38YmD13E9hxm5n1/IoMnUQdVrj/2xRK1oPzRjdRWgrmxd/iiWVA9HjeII+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=A8kfk27k; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="A8kfk27k" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3cfce97a3d9so13550485ab.2 for ; Mon, 14 Apr 2025 07:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1744642073; x=1745246873; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fq48PAOknFOAzKFbEqBjcV5Kzd2DBdHXfQElMB85zFI=; b=A8kfk27kPDo7TcTKi0fMmDCu+ujbGwClggFgN3TgVxfalKaUlRDE/mu17SYUH9uAc3 ya1iSH7RwHwxjHgJPqChaWgw5aTVNZj6wKCAzsp4py2kh6kwR2k/wvXLYHSaXDKcq3zJ HvDiyclan2wVxYWoR/BFXVmnjENzS2fHbqJutlsvPOL62H0FUJY5NWol5wNbT9rYzgRO elMijkQtGIHtfO168zkRYs6mSS+ZDK71wPrYMTmAW4L1/9ln71NJc5+bU0rU2xbbcEzV TXYch1BirqHrf8YgWHOPFfxPBMYQCL/y3283Z1/Z6lnAHjOQx7qa9GUsK2I6kUuVTmnm S+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744642073; x=1745246873; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fq48PAOknFOAzKFbEqBjcV5Kzd2DBdHXfQElMB85zFI=; b=tg/09EbStKy7/Dmttg+BySIrQitj4qH7RwDKbCezw2NbdnV6e+zMM3DmXv06bWSVLG 6dITS+wBA2JU/5FPWZYoDETGdrW2k0DT4O6dKLMStV5LyAZH13xVlkVbRLZ8SZ4PM5y+ RqWBs3B0n3oMVcuXcHM+hjyVqhYNSZPRBZHg3s51/5rNsf/J4/nesqgs+Z4wdnFP0/MS QEus/kKS5VR8uVT+rwVvL1YQI7LCSWMJIiPnoviexhwRjZKVY6ulBKTZKmLEN19oRLJc Zm7nxkg9v2LGXCFPs9GuV/hQskNIGozrzuNJiL62ge2d5XzbmI8is57J9jKG/pcrQOgY Lj6Q== X-Gm-Message-State: AOJu0YyXBxaVpe2r9J31g3z5I/vGiilyPi7WJC77EruaSNI5vaFpqn5s Qq8oIahh6XhejDDh/MgXmYoTNl0UFeRBj2STwKXhRXSipIzDjvv0ciB5NLmgmB5JJWxj3P2rf0R y X-Gm-Gg: ASbGncvH1CcSl3taLw1qZxkltC5fCofrgJfSsOOoSkvqBoCTed8NG7PBGWaZY8BHU18 gcX6I9FUuhRIpYqg0AvZ0F50nV1ezuuD4LMbweMTusiaTr2ylui+JR+2ppTe2fS13oleIVsB/xS /0l974Ik9HWifOYO7x3U5hWdAJkdVfhDe4QI9mB/l2AUmL+JHc7PzYFnww8viBYw2CRIeXNh18h ktiWQXKSJjodlGq82GuZtK7Z1n7t16UvlRWc7z7k+uVRujjkAasfwCkc0Rd2BQ+HvwImrePnnZi IhWz0JfdjtjpoLWl7Shx5jNNOpXnvSXCKNOXTw== X-Google-Smtp-Source: AGHT+IE/jRticyjdHacClb5ym5jstPEP9CrlXUCBcGw7k00gcOTS5NpmDKrmPTfewbzW1VzTeVMVjA== X-Received: by 2002:a05:6e02:989:b0:3d6:d162:be12 with SMTP id e9e14a558f8ab-3d7ec277267mr98023065ab.21.1744642073536; Mon, 14 Apr 2025 07:47:53 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d7dc591f82sm27637385ab.65.2025.04.14.07.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 07:47:52 -0700 (PDT) Message-ID: Date: Mon, 14 Apr 2025 08:47:51 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] loop: aio inherit the ioprio of original request To: Christoph Hellwig , Yunlong Xing Cc: linux-block@vger.kernel.org, bvanassche@acm.org, niuzhiguo84@gmail.com, yunlongxing23@gmail.com, linux-kernel@vger.kernel.org, hao_hao.wang@unisoc.com, zhiguo.niu@unisoc.com References: <20250414030159.501180-1-yunlong.xing@unisoc.com> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/14/25 12:12 AM, Christoph Hellwig wrote: > On Mon, Apr 14, 2025 at 11:01:59AM +0800, Yunlong Xing wrote: >> Set cmd->iocb.ki_ioprio to the ioprio of loop device's request. >> The purpose is to inherit the original request ioprio in the aio >> flow. > > This looks good, but has a mechanical conflict with my > "loop: stop using vfs_iter_{read,write} for buffered I/O" patch > that fixes setting the block size for direct I/O. > > Jens, any preference how we should order the patches? Should I resend > on top of this smaller one or the other way around? I think we layer yours on top of this one, which is something I can just do without much trouble. Do we want the vfs_iter removal in 6.15 or is 6.16 fine for that? -- Jens Axboe