From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: linux-block <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Shaohua Li <shli@fb.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: testing io.low limit for blk-throttle
Date: Mon, 23 Apr 2018 16:26:10 +0800 [thread overview]
Message-ID: <e11cb30e-0699-bc5f-522f-a56d9a00896d@oracle.com> (raw)
In-Reply-To: <61EA7529-E6F7-4708-A621-CCAC1FBFFCF8@linaro.org>
Hi Paolo
When I test execute the script, I got this
8:0 rbps=10000000 wbps=0 riops=0 wiops=0 idle=0 latency=max
The idle is 0.
I'm afraid the io.low would not work.
Please refer to the following code in tg_set_limit
/* force user to configure all settings for low limit */
if (!(tg->bps[READ][LIMIT_LOW] || tg->iops[READ][LIMIT_LOW] ||
tg->bps[WRITE][LIMIT_LOW] || tg->iops[WRITE][LIMIT_LOW]) ||
tg->idletime_threshold_conf == DFL_IDLE_THRESHOLD || //-----> HERE
tg->latency_target_conf == DFL_LATENCY_TARGET) {
tg->bps[READ][LIMIT_LOW] = 0;
tg->bps[WRITE][LIMIT_LOW] = 0;
tg->iops[READ][LIMIT_LOW] = 0;
tg->iops[WRITE][LIMIT_LOW] = 0;
tg->idletime_threshold = DFL_IDLE_THRESHOLD;
tg->latency_target = DFL_LATENCY_TARGET;
} else if (index == LIMIT_LOW) {
tg->idletime_threshold = tg->idletime_threshold_conf;
tg->latency_target = tg->latency_target_conf;
}
blk_throtl_update_limit_valid(tg->td);
Thanks
Jianchao
On 04/23/2018 03:37 PM, Paolo Valente wrote:
> cd thr-lat-with-interference
> sudo ./thr-lat-with-interference.sh -b t -w 100000000 -W "10000000 10000000 10000000 10000000 10000000 10000000" -n 6 -T "read read read read read read" -R "0 0 0 0 0 0"
next prev parent reply other threads:[~2018-04-23 8:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 9:23 testing io.low limit for blk-throttle Paolo Valente
2018-04-22 13:29 ` jianchao.wang
2018-04-22 15:53 ` Paolo Valente
2018-04-23 2:19 ` jianchao.wang
2018-04-23 5:32 ` Paolo Valente
2018-04-23 6:35 ` jianchao.wang
2018-04-23 7:37 ` Paolo Valente
2018-04-23 8:26 ` jianchao.wang [this message]
2018-04-23 6:05 ` Joseph Qi
2018-04-23 7:35 ` Paolo Valente
2018-04-23 9:01 ` Joseph Qi
2018-04-24 12:12 ` Paolo Valente
2018-04-25 12:13 ` Joseph Qi
2018-04-26 17:27 ` Paolo Valente
2018-04-27 3:27 ` Joseph Qi
2018-04-27 5:14 ` Paolo Valente
2018-04-26 18:32 ` Tejun Heo
2018-04-27 2:09 ` jianchao.wang
2018-04-27 2:40 ` Joseph Qi
2018-05-03 16:35 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11cb30e-0699-bc5f-522f-a56d9a00896d@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=shli@fb.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox