From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2 1/5] block: Introduce a request queue flag for pipelining zoned writes
Date: Tue, 18 Jul 2023 15:37:08 -0700 [thread overview]
Message-ID: <e1af3db6-0614-d0f2-a8c4-eb2a1de82e85@acm.org> (raw)
In-Reply-To: <9feab737-acb6-9e03-effb-8b130fdfa12a@kernel.org>
On 7/17/23 23:34, Damien Le Moal wrote:
> On 7/11/23 03:01, Bart Van Assche wrote:
>> +/* Writes for sequential write required zones may be pipelined. */
>> +#define QUEUE_FLAG_PIPELINE_ZONED_WRITES 8
>
> I am not a big fan of this name as "pipeline" does not necessarily imply "high
> queue depth write". What about simply calling this
> QUEUE_FLAG_NO_ZONE_WRITE_LOCK, indicating that there is no need to write-lock
> zones ?
Hi Damien,
I'm not a big fan of names with negative words like "no" or "not" embedded.
Isn't pipelining standard computer science terminology? See also
https://en.wikipedia.org/wiki/Pipeline_(computing).
Thanks,
Bart.
next prev parent reply other threads:[~2023-07-18 22:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 18:01 [PATCH v2 0/5] Enable zoned write pipelining for UFS devices Bart Van Assche
2023-07-10 18:01 ` [PATCH v2 1/5] block: Introduce a request queue flag for pipelining zoned writes Bart Van Assche
2023-07-18 6:34 ` Damien Le Moal
2023-07-18 22:37 ` Bart Van Assche [this message]
2023-07-19 9:58 ` Damien Le Moal
2023-07-10 18:01 ` [PATCH v2 2/5] block/mq-deadline: Only use zone locking if necessary Bart Van Assche
2023-07-18 6:38 ` Damien Le Moal
2023-07-18 22:38 ` Bart Van Assche
2023-07-24 21:39 ` Bart Van Assche
2023-07-10 18:01 ` [PATCH v2 3/5] block/null_blk: Add support for pipelining zoned writes Bart Van Assche
2023-07-10 18:01 ` [PATCH v2 4/5] scsi: Retry unaligned " Bart Van Assche
2023-07-18 6:47 ` Damien Le Moal
2023-07-18 22:53 ` Bart Van Assche
2023-07-19 9:59 ` Damien Le Moal
2023-07-19 16:31 ` Bart Van Assche
2023-07-19 23:07 ` Damien Le Moal
2023-07-20 18:18 ` Bart Van Assche
2023-07-21 0:20 ` Damien Le Moal
2023-07-10 18:01 ` [PATCH v2 5/5] scsi: ufs: Enable zoned write pipelining Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1af3db6-0614-d0f2-a8c4-eb2a1de82e85@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).