From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] direct-io: remove IOCB_NOWAIT support
Date: Mon, 18 May 2026 11:34:10 +0200 [thread overview]
Message-ID: <e20941eb-da39-452d-a2d9-bd67c1a4ada3@kernel.org> (raw)
In-Reply-To: <20260518063336.507369-2-hch@lst.de>
On 2026/05/18 8:33, Christoph Hellwig wrote:
> None of the file systems using the legacy direct I/O code actually sets
> FMODE_NOWAIT, and if they did this would not work, as the write locking
> could not handle the retry. Remove this dead code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-18 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 6:33 REQ_NOAIT cleanups Christoph Hellwig
2026-05-18 6:33 ` [PATCH 1/2] direct-io: remove IOCB_NOWAIT support Christoph Hellwig
2026-05-18 9:34 ` Damien Le Moal [this message]
2026-05-18 12:09 ` Jan Kara
2026-05-18 12:26 ` Christian Brauner
2026-05-18 6:33 ` [PATCH 2/2] block: don't set BIO_QUIET for BLK_STS_AGAIN Christoph Hellwig
2026-05-18 9:34 ` Damien Le Moal
2026-05-18 12:34 ` Jan Kara
2026-05-18 12:51 ` Christoph Hellwig
2026-05-18 13:03 ` Jan Kara
2026-05-26 16:37 ` REQ_NOAIT cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e20941eb-da39-452d-a2d9-bd67c1a4ada3@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox