From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E8C15957C for ; Tue, 16 Jan 2024 20:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435235; cv=none; b=JHd/VMeabPMNUnC5pWJFuwkxQ8Ot3m4CK/0pzOfWYNxp4GLeEm1Q8IPlrpe39b1pYUBy/UWrzx4V2kjj2V980ujLYSpkQP6Eu6gXejG4yzHbI1T5XtlDWgDifkCw/YgDAdzNZzg6rVSc90D1Oy363BbGkpRez+6kPONdLBuIbZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705435235; c=relaxed/simple; bh=0LpxdPDwIhXx9whWgjBylXCRhboUwUu+jIA/F2NRoWc=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:Content-Language: To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=L/xfzYy+0rrNrhRqtMMjERWzOMr2RMVLRDPIUR+El7Dk6ggKlzui+koC6y8kmYz0ICQ3DAMxbTZl3SOE2Q0ynY/yzM+Z4UdQgD2RMhz9UsJK1ONtLQWfTcI6sGtYRUJbS2bE609Juo3Rv9fy5znAPnWGSAGaSjtQlLJhtFjTUdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=IimP4Pc1; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="IimP4Pc1" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3618c6a1d30so724375ab.0 for ; Tue, 16 Jan 2024 12:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705435230; x=1706040030; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8Bzi0VNEZLd3xkt69kN62PfQd5yOGDUdslJTECLXFRg=; b=IimP4Pc1UlT1Dxvn4rthZMYDf19IAeO/EBFr2fLbWHMWHQjjlbujtucKNyTHweQTI8 n7sWGwfxGb3TB7t1++rN5fAN5rRwxq07taKD/AwzUSiJPkbjrTVwg60yhn0ZhuRuaa8B b3KbQHJxndhscKKaJmye9Kve//SiKKfNlfFJxpWCbifNWgQfVnmO00ZBmFFL19bDXmkz 7VMeRnrPGgsNj3AhzWQzWSdQcq0ww4/76/fZcrUGwupAmfQQ1ykoCjwfcGgZSnhlJB9y +ItHxEb74pD+c9EBNnpijdHENmIYJdCqY/D3sZIe/qWH+r56qXn5KAKiW65hFQovuL39 KARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705435230; x=1706040030; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8Bzi0VNEZLd3xkt69kN62PfQd5yOGDUdslJTECLXFRg=; b=Ymx9WD2OkvbYV8GWvemuvS0DlX9UK/7KGHnf2EYEQ6pzHFap22QEmmf0Ufho3g26JW Xlyj1a7YIxkIaeNhGQrqcWukXRS1/RseHfPbu2eedFtmxwXvraEVwY8zSeCmXbG5Mqb3 RvZ6bc6TQpyH9anF257NKRacVJBPUdDbw8zcs6H6QjEFU9pf81swobF7WY8nZ37XQ4Hc GRBR6PhhzpD8uoEpJ5NjYm+IE38avkiTqppmqO+arExRwBt2OpkzEmLvQvXoP/13elNJ 6EkenKMarGrafEs1wuhZk37ScEZjnMdEoXSxCaIyjTNWOAX76xS6kHaDPkJbH1wcWAqT nPgg== X-Gm-Message-State: AOJu0YxTgL8PhOmF/uGLMHOHUcMmCNFEshpWDCp+OQQ/dIeH9+YXA9YC PTuLYSyV81EFKGiBDDdy3DsHG3+Sf/d/KA== X-Google-Smtp-Source: AGHT+IGD/c0B/2oUpgwDPKxeGeaTpllkQKnSoDSKBOTPLNpwFPFn9e3DteSXI03hU/LqVgKuvSnt4Q== X-Received: by 2002:a6b:c845:0:b0:7bc:2603:575f with SMTP id y66-20020a6bc845000000b007bc2603575fmr14558885iof.0.1705435230304; Tue, 16 Jan 2024 12:00:30 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id b8-20020a029a08000000b0046e1efd2e1dsm3079962jal.74.2024.01.16.12.00.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 12:00:29 -0800 (PST) Message-ID: Date: Tue, 16 Jan 2024 13:00:29 -0700 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [block?] BUG: unable to handle kernel NULL pointer dereference in __bio_release_pages Content-Language: en-US To: Matthew Wilcox Cc: syzbot , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000dbe2f2060f0d2781@google.com> <4bd438c0-75b8-4e28-939c-954716df7563@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/16/24 11:42 AM, Matthew Wilcox wrote: > On Tue, Jan 16, 2024 at 11:00:52AM -0700, Jens Axboe wrote: >> On 1/16/24 2:57 AM, syzbot wrote: >>> pstate: 10000005 (nzcV daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) >>> pc : _compound_head include/linux/page-flags.h:247 [inline] >>> pc : bio_first_folio include/linux/bio.h:289 [inline] >>> pc : __bio_release_pages+0x100/0x73c block/bio.c:1153 >>> lr : bio_release_pages include/linux/bio.h:508 [inline] >>> lr : blkdev_bio_end_io+0x2a0/0x3f0 block/fops.c:157 >>> sp : ffff800089a375e0 >>> x29: ffff800089a375e0 x28: 1fffe0000162e879 x27: ffff00000b1743c0 >>> x26: ffff00000b1743c8 x25: 000000000000000a x24: 1fffe000015a9e12 >>> x23: ffff00000ad4f094 x22: ffff00000f496600 x21: 1fffe0000162e87a >>> x20: 0000000000000004 x19: 0000000000000000 x18: ffff00000b174432 >>> x17: ffff00000b174438 x16: ffff00000f948008 x15: 1fffe0000162e886 >>> x14: ffff00000b1743d4 x13: 00000000f1f1f1f1 x12: ffff6000015a9e13 >>> x11: 1fffe000015a9e12 x10: ffff6000015a9e12 x9 : dfff800000000000 >>> x8 : ffff00000b1743d4 x7 : 0000000041b58ab3 x6 : 1ffff00011346ed0 >>> x5 : ffff700011346ed0 x4 : 00000000f1f1f1f1 x3 : 000000000000f1f1 >>> x2 : 0000000000000001 x1 : dfff800000000000 x0 : 0000000000000008 >>> Call trace: >>> _compound_head include/linux/page-flags.h:247 [inline] >>> bio_first_folio include/linux/bio.h:289 [inline] >>> __bio_release_pages+0x100/0x73c block/bio.c:1153 >>> bio_release_pages include/linux/bio.h:508 [inline] >>> blkdev_bio_end_io+0x2a0/0x3f0 block/fops.c:157 >>> bio_endio+0x4a4/0x618 block/bio.c:1608 >> >> This looks to be caused by: >> >> commit 1b151e2435fc3a9b10c8946c6aebe9f3e1938c55 >> Author: Matthew Wilcox (Oracle) >> Date: Mon Aug 14 15:41:00 2023 +0100 >> >> block: Remove special-casing of compound pages > > This looks familiar ... looks like it came up right before Xmas and > I probably dropped the patch on the floor? > > https://lore.kernel.org/all/ZX07SsSqIQ2TYwEi@casper.infradead.org/ Can you send out a proper patch please? -- Jens Axboe