From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm: move filemap_range_needs_writeback() into header
Date: Fri, 3 Dec 2021 10:57:50 -0700 [thread overview]
Message-ID: <e386e230-4eef-f4da-f327-9b0f1d33fe47@kernel.dk> (raw)
In-Reply-To: <YapYAt7+r7K0aQ3+@casper.infradead.org>
On 12/3/21 10:46 AM, Matthew Wilcox wrote:
> On Fri, Dec 03, 2021 at 09:38:25AM -0700, Jens Axboe wrote:
>> On 12/3/21 9:35 AM, Jens Axboe wrote:
>>> On 12/3/21 9:31 AM, Jens Axboe wrote:
>>>> On 12/3/21 9:24 AM, Jens Axboe wrote:
>>>>> On 12/3/21 9:16 AM, Matthew Wilcox wrote:
>>>>>> On Fri, Dec 03, 2021 at 08:38:28AM -0700, Jens Axboe wrote:
>>>>>>> +++ b/include/linux/fs.h
>>>>>>
>>>>>> fs.h is the wrong place for these functions; they're pagecache
>>>>>> functionality, so they should be in pagemap.h.
>
> I think you missed this ^^^
I did... That would mean moving some more of the declarations too. Prep patch
or just part of this patch?
>>>> That does introduce a dependency from fs.h -> pagemap.h which isn't trivially
>>>> resolvable...
>>>>
>>>> What if we just rename the above funciton to mapping_has_pages() or something
>>>> instead?
>>>
>>> Or just drop the helper, to be honest. There are more tests for
>>> mapping->nrpages right now than there are callers of this silly little
>>> helper.
>>
>> Like this:
>
> I'm happy with this, if you just move it to pagemap.h
OK, I'll try it out.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-03 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 15:38 [PATCHSET 0/2] Avoid unnecessary indirect calls for bdev dio Jens Axboe
2021-12-03 15:38 ` [PATCH 1/2] mm: move filemap_range_needs_writeback() into header Jens Axboe
2021-12-03 16:16 ` Matthew Wilcox
2021-12-03 16:24 ` Jens Axboe
2021-12-03 16:31 ` Jens Axboe
2021-12-03 16:35 ` Jens Axboe
2021-12-03 16:38 ` Jens Axboe
2021-12-03 17:46 ` Matthew Wilcox
2021-12-03 17:57 ` Jens Axboe [this message]
2021-12-03 18:01 ` Jens Axboe
2021-12-03 18:14 ` Matthew Wilcox
2021-12-03 19:09 ` Jens Axboe
2021-12-03 15:38 ` [PATCH 2/2] block: move direct_IO into our own read_iter handler Jens Axboe
2021-12-06 6:58 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e386e230-4eef-f4da-f327-9b0f1d33fe47@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox