Re: [GIT PULL] Block updates for 6.9-rc1

Mike Snitzer
2024-03-12T00:25:38Z

On Mon, Mar 11 2024 at 8:02P -0400,
Jens Axboe <axboe@kernel.dk> wrote:

> On 3/11/24 5:58 PM, Linus Torvalds wrote:
> > On Mon, 11 Mar 2024 at 16:50, Johannes Weiner <hannes@cmpxchg.org> wrote:
> >>
> >> My desktop fails to decrypt /home on boot with this:
> >
> > Yup. Same here. I'm actually in the middle of bisect, just got to the
> > block pull, and was going to report that the pull was broken.
> >
> > I don't have a full bisect done yet.
>
> Just revert that commit it for now. Christoph has a pending fix, but it
> wasn't reported against this pretty standard use case.

That fix is specific to discards being larger than supported (and FYI,
I did include it in the dm-6.9 pull request).

But Hannes' backtrace points to block/blk-settings.c:192 which is:

if (WARN_ON_ONCE(lim->max_segment_size &&
lim->max_segment_size != UINT_MAX))
return -EINVAL;
lim->max_segment_size = UINT_MAX;

> Very odd that we haven't seen that yet.

It is odd. dm-6.9 is based on the block tree for 6.9, which included
8e0ef412869 ("dm: use queue_limits_set"). And I ran the full
cryptsetup testsuite against my for-next branch to validate dm-crypt
and dm-verity working with Tejun's BH workqueue changes.

I agree with reverting commit 8e0ef412869 -- but again hch's fix was
for something else and really can stand on its own even independent of
commit 8e0ef412869

Mike