From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63429C433E3 for ; Thu, 16 Jul 2020 15:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 415DC20787 for ; Thu, 16 Jul 2020 15:45:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="yc4RnboI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729175AbgGPPpp (ORCPT ); Thu, 16 Jul 2020 11:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729130AbgGPPpo (ORCPT ); Thu, 16 Jul 2020 11:45:44 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1374AC061755 for ; Thu, 16 Jul 2020 08:45:44 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id y2so6514771ioy.3 for ; Thu, 16 Jul 2020 08:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Tx/hUhqJAjXkev40Jb9OVrKXoukmWH1wNBtfngv1/sY=; b=yc4RnboIQMLq3CDak3WwAyj7ppF1bGUno0SLnNg2VBzMUR9N4zOyzuxgsml+LgwHoB ysEFbrig6lXnRPbp533Tb+2k1nMKJrfIx1OUfd+oBRKa/8cP/GeP7DtVM7wMXX59oZrc TMue8U4xfvt7ytA8XcknosKvaaf6GdgTFhbs7p2K8FpODu6xMN9CGDVCt3BXy9EUhQ5j V6iAhQEao2CXGAXmTiXhk2h2q855hsUwCVbsh7bSpY7E6LiVll7mwDp3ZKnKGWcm1/Mp ZzFkeelBmFZu+9P9/m/nKK8yQkS3BZeCfNGqtwIyCsqtZX8rKhmmm5/pRjzId4qU6Gp1 C3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Tx/hUhqJAjXkev40Jb9OVrKXoukmWH1wNBtfngv1/sY=; b=T17OviOateG35MT7ltSXgAAszLpWYoLRnxWjR4xUlnXmVtI/MZyfXQ9xjxl2MDhZor sJ+wp2sQ1xqIQzEB4ofXAAMcPAb35TSJGawFMjSYV63fwPxtpvZs/+YBmV99/6aFnc3E LaZLv2tWBAcSt0fegX8EIrjzD7H0nTOaAZ2BY1yuXr6CNRvAizmpE3EItZRkTq4ydyHg BaY8ISFJZ2YcwBzAibS/RSMp5577R2Ng9T55eAbARJ8PhnFYuCVGfpJPAw6gyIq3OOut izSQh8pQ1EwyrBnc+Hc29iEjZkMGSTTifwy/lYB17NnVl8zmSc6oSYHfnHhY1X3ouHDN NRow== X-Gm-Message-State: AOAM533NulNwDV1Pb53fwiP6wHcyLJI8m9VylajyCRvGCvw3GJX+un10 eiwap8BNqxG3i1fJnGNi7vM06VbNKsqqxA== X-Google-Smtp-Source: ABdhPJxF850bmoBLpclUx2eq04KON8mHvr6Ay/QHFbo24vQEXQSggVEJ5YQYda0SUwxpCWYnpoSWlA== X-Received: by 2002:a05:6602:5c3:: with SMTP id w3mr820159iox.3.1594914342258; Thu, 16 Jul 2020 08:45:42 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id w16sm3209054iom.27.2020.07.16.08.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 08:45:41 -0700 (PDT) Subject: Re: [PATCH -next] rsxx: Convert to DEFINE_SHOW_ATTRIBUTE To: Qinglang Miao , Greg Kroah-Hartman , Joshua Morris , Philip Kelleher Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200716090432.13691-1-miaoqinglang@huawei.com> From: Jens Axboe Message-ID: Date: Thu, 16 Jul 2020 09:45:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200716090432.13691-1-miaoqinglang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 7/16/20 3:04 AM, Qinglang Miao wrote: > From: Liu Shixin > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. None of these apply against the 5.9 block tree, looks like some read -> read_iter conversion has happened in another branch that I'm not privy to. -- Jens Axboe