Linux block layer
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Qiliang Yuan <qiliang.yuan@linux.dev>,
	Jens Axboe <axboe@kernel.dk>, Damien Le Moal <dlemoal@kernel.org>,
	Ming Lei <tom.leiming@gmail.com>,
	Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 2/2] block: return early when the elevator doesn't change
Date: Tue, 17 Nov 2026 16:20:17 +0100	[thread overview]
Message-ID: <e50ff1ab-ff60-449e-9a8e-acfdbf157449@suse.de> (raw)
In-Reply-To: <20261116-bug-block-elevator-unchanged-v3-2-cb4dda2dadf4@linux.dev>

On 11/17/26 3:56 AM, Qiliang Yuan wrote:
> Writing the scheduler a queue already uses to queue/scheduler used to
> be a no-op. elevator_change() now only checks for an unchanged elevator
> after freezing the queue, and doesn't treat "none" on a queue without
> an elevator as unchanged at all, so that case also quiesces the queue
> in elevator_switch() and resets nr_requests.
> 
> Every such write therefore drains in-flight I/O and waits for an RCU
> grace period. udev rules and tuning tools that set the scheduler
> unconditionally stall I/O on live disks each time they run.
> 
> Check under elevator_lock whether anything would change before
> allocating scheduler resources and freezing the queue. The check can
> race with another elevator change, which at worst leads to a redundant
> switch, so keep the one done under the freeze as well.
> 
> Writing the current scheduler to queue/scheduler of a null_blk disk 20
> times takes (median):
> 
>    operation                 before (ms)  after (ms)  change
>    none -> none                     9.11        0.08    -99%
>    mq-deadline -> mq-deadline       9.05        0.08    -99%
> 
> 4k random reads at queue depth 1 for 10 seconds, while "none" is
> written to queue/scheduler every 50 ms:
> 
>    metric             before  after  change
>    IOPS               340562 390392    +15%
>    max latency (us)    16302   1224    -92%
> 
> Fixes: af2814149883e ("block: freeze the queue in queue_attr_store")
> Signed-off-by: Qiliang Yuan <qiliang.yuan@linux.dev>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
>   block/elevator.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index 9d9b2e84a1288..549cf51543a8b 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -654,10 +654,24 @@ static int elevator_change(struct request_queue *q, struct elv_change_ctx *ctx)
>   {
>   	unsigned int memflags;
>   	struct blk_mq_tag_set *set = q->tag_set;
> +	bool unchanged;
>   	int ret = 0;
>   
>   	lockdep_assert_held(&set->update_nr_hwq_lock);
>   
> +	/*
> +	 * Skip freezing the queue if nothing would change. This can race with
> +	 * another elevator change, which at worst leads to a redundant switch.
> +	 */
> +	mutex_lock(&q->elevator_lock);
> +	if (q->elevator)
> +		unchanged = elevator_match(q->elevator->type, ctx->name);
> +	else
> +		unchanged = !strncmp(ctx->name, "none", 4);
> +	mutex_unlock(&q->elevator_lock);
> +	if (unchanged)
> +		return 0;
> +
>   	if (strncmp(ctx->name, "none", 4)) {
>   		ret = blk_mq_alloc_sched_res(q, ctx->type, &ctx->res,
>   				set->nr_hw_queues);
> 

Reviewed-by: Hannes Reinecke <hare@kernel.org>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

      parent reply	other threads:[~2026-11-17 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:56 [PATCH v3 0/2] block: make changing to the current I/O scheduler cheap again Qiliang Yuan
2026-11-17  2:56 ` [PATCH v3 1/2] block: don't request a module for the none elevator Qiliang Yuan
2026-11-17 15:19   ` Hannes Reinecke
2026-11-17  2:56 ` [PATCH v3 2/2] block: return early when the elevator doesn't change Qiliang Yuan
2026-11-17 14:54   ` Nilay Shroff
2026-11-17 15:20   ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e50ff1ab-ff60-449e-9a8e-acfdbf157449@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    --cc=qiliang.yuan@linux.dev \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox