Re: [PATCH v7 3/3] scsi: bsg: add io_uring passthrough handler

[Bart Van Assche <bvanassche@acm.org>]

On 3/12/26 2:22 AM, Yang Xiuwei wrote:
> +/*
> + * Per-command BSG SCSI PDU stored in io_uring_cmd.pdu[32].
> + * Holds temporary state between submission, completion and task_work.
> + */
> +struct scsi_bsg_uring_cmd_pdu {
> +	struct bio *bio;		/* mapped user buffer, unmap in task work */
> +	struct request *req;		/* block request, freed in task work */
> +	u64 response_addr;		/* user space response buffer address */
> +};

A static_assert() that verifies that sizeof(struct
scsi_bsg_uring_cmd_pdu) is less than or equal to the size of
((struct io_uring_cmd *)NULL)->pdu seems appropriate here.

> +/* Task work: build res2 (layout in uapi/linux/bsg.h) and copy sense to user. */
> +static void scsi_bsg_uring_task_cb(struct io_tw_req tw_req, io_tw_token_t tw)
> +{
> +	struct scsi_bsg_uring_cmd_pdu *pdu;
> +	struct io_uring_cmd *ioucmd = io_uring_cmd_from_tw(tw_req);
> +	struct scsi_cmnd *scmd;
> +	struct request *rq;
> +	u64 res2;
> +	int ret = 0;
> +	u8 driver_status = 0;
> +	u8 sense_len_wr = 0;
> +
> +	pdu = scsi_bsg_uring_cmd_pdu(ioucmd);
> +	rq = pdu->req;
> +	scmd = blk_mq_rq_to_pdu(rq);

Please combine the above three assignments with the above declarations
since that is the style followed by most kernel code.

Otherwise this patch series looks good to me.

Thanks,

Bart.