From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD72CD37B0 for ; Mon, 18 Sep 2023 16:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjIRQC4 (ORCPT ); Mon, 18 Sep 2023 12:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjIRQCz (ORCPT ); Mon, 18 Sep 2023 12:02:55 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC42A3C35 for ; Mon, 18 Sep 2023 09:00:10 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-76eecd12abbso77251885a.0 for ; Mon, 18 Sep 2023 09:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695052552; x=1695657352; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bC2phskuIFvD/AaiWBQwD/RidKu+taALyCRQa/nknSE=; b=l2aJOcTwnr4VKLPCJMI3xvPby4xgyOk6TmntmpGu5lawEj5WGJXBFS/WAjBvd+qraT n8JOC14SqRQpwcsMs8EZrqDVJOvyYtSptSA2Zfa/hafAB698WHETYweV02KlUGRhTt/4 6pJTJPlzz7EmEdOqyG8ziDE8An3l6lVfNUbUbqvv3s7wycM8Zjnzz0nFOhkxV49wRAJe hmCCRc09aNzLj8Vd9wFQPN5Ssk6EtXwD2bZ5KYvv25O0KchSSLSaf6QjaDP/PnRV977r kdqxY+Q4C7Xq4bXquxn6IeNkilhE6O3DQv0Ou5QmFIdXHi69NDbY37unF7YuDyj88PcA F7bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695052552; x=1695657352; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bC2phskuIFvD/AaiWBQwD/RidKu+taALyCRQa/nknSE=; b=Y1qWmPMpC+FwfUxVu4ewiJvxkk7sUt4amJCtnd7SIjwyED67UbGVaMRmJLuZXTVCrM pSaSUwl9mcYADnwFIJynih04ETxOZmocOLz0LTIHcC8Zvj5vhcQzkGebdmXzmmrlXGNX ebIqOEBmtcD/SEtoFmzZULkzX+wV7vQUQp6r32u0r1Os+ilfIfKkLddznGFnB6PUWQWe crePnGwNkuWutcedcpYthpMMIXGX00xwW5XjlsLUs9PvOy0ZfN9VV0UiKU6t1kTt0tTb GlNZxFC9FrYqDKBy2uzE5NMflGj4WrVCITyafT6+9lFNKwY4Y+HvXDkyDwyhiQ7t78y9 L5hQ== X-Gm-Message-State: AOJu0YyOG2sG+FWdpcFInKjxDHGbUBMuSbX41UmBeZNJAgzpQTsAJPIQ ob9oH+D0hjgk2eEggagdasfTAkAnzxAc7QhXZtK0fA== X-Google-Smtp-Source: AGHT+IE4huNJ9ieYLbRr1wXk9YJVyZSV0RaDTxWDJMPdpQYjKG794yWqTTw/d7v2WKKlkf7zMRwoMQ== X-Received: by 2002:a6b:c94d:0:b0:795:172f:977a with SMTP id z74-20020a6bc94d000000b00795172f977amr9665856iof.1.1695045646340; Mon, 18 Sep 2023 07:00:46 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id em8-20020a0566384da800b0042b068d921esm2836235jab.16.2023.09.18.07.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 07:00:45 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 08:00:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aoe: refactor deprecated strncpy Content-Language: en-US To: Justin Stitt Cc: Kees Cook , Justin Sanders , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Xu Panda , Yang Yang References: <20230911-strncpy-drivers-block-aoe-aoenet-c-v1-1-9643d6137ff9@google.com> <202309142019.23A7D80A@keescook> <6338fbac-0177-43eb-be4f-7c586956953f@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/18/23 1:03 AM, Justin Stitt wrote: >> Change looks fine to me too, but for the love of $deity, please use >> a proper subject line for these kinds of patches. It's not refactoring >> anything. >> > > Fair. > > Perhaps "xyz: replace strncpy with strscpy"? That's a lot more descriptive, as a) it's actually accurate, and b) this is what the patch does. You just sent another one with this refactor wording which makes zero sense, please resend this and others targeted at block with a proper description. -- Jens Axboe