From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "osandov@fb.com" <osandov@fb.com>
Subject: Re: [PATCH 1/4] block: remove REQ_ATOM_POLL_SLEPT
Date: Wed, 10 Jan 2018 11:32:43 -0700 [thread overview]
Message-ID: <e7924d15-6160-ed15-039c-ed2bfee417e4@kernel.dk> (raw)
In-Reply-To: <1515608737.2745.11.camel@wdc.com>
On 1/10/18 11:25 AM, Bart Van Assche wrote:
> On Tue, 2018-01-09 at 17:29 -0700, Jens Axboe wrote:
>> We don't need this to be an atomic flag, it can be a regular
>> flag. We either end up on the same CPU for the polling, in which
>> case the state is sane, or we did the sleep which would imply
>> the needed barrier to ensure we see the right state.
>
> Please consider updating rqf_name[] in blk-mq-debugfs.c.
Good catch - I'll do that, and also add a small prep patch that syncs
with the current situation, looks like we're missing the timeout
and zone locked flags.
--
Jens Axboe
next prev parent reply other threads:[~2018-01-10 18:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 0:29 [PATCHSET v2 0/4] struct request optimizations Jens Axboe
2018-01-10 0:29 ` [PATCH 1/4] block: remove REQ_ATOM_POLL_SLEPT Jens Axboe
2018-01-10 18:25 ` Bart Van Assche
2018-01-10 18:32 ` Jens Axboe [this message]
2018-01-10 18:35 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 2/4] block: add accessors for setting/querying request deadline Jens Axboe
2018-01-10 18:27 ` Bart Van Assche
2018-01-10 18:41 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 3/4] block: convert REQ_ATOM_COMPLETE to stealing rq->__deadline bit Jens Axboe
2018-01-10 18:29 ` Bart Van Assche
2018-01-10 18:32 ` Jens Axboe
2018-01-10 18:33 ` Bart Van Assche
2018-01-10 18:35 ` Jens Axboe
2018-01-10 18:42 ` Bart Van Assche
2018-01-10 18:45 ` Omar Sandoval
2018-01-10 0:29 ` [PATCH 4/4] block: rearrange a few request fields for better cache layout Jens Axboe
2018-01-10 18:34 ` Bart Van Assche
2018-01-10 18:43 ` Omar Sandoval
2018-01-10 18:45 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2018-01-09 18:26 [PATCHSET 0/4] struct request optimizations Jens Axboe
2018-01-09 18:26 ` [PATCH 1/4] block: remove REQ_ATOM_POLL_SLEPT Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7924d15-6160-ed15-039c-ed2bfee417e4@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).