From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Jinpu Wang <jinpu.wang@ionos.com>,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
Cc: "haris.iqbal@ionos.com" <haris.iqbal@ionos.com>,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"grzegorz.prajsner@ionos.com" <grzegorz.prajsner@ionos.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] rnbd-clt: fix refcount underflow in device unmap path
Date: Thu, 15 Jan 2026 07:20:43 -0700 [thread overview]
Message-ID: <e7fd9926-4e67-4396-ba84-c9749a9c7d1c@kernel.dk> (raw)
In-Reply-To: <bc5b7643-8f6e-4801-8d73-06e869318cd6@nvidia.com>
On 1/14/26 6:58 PM, Chaitanya Kulkarni wrote:
> On 1/14/26 00:40, Jinpu Wang wrote:
>>> This follows the kernel pattern where sysfs removal (kobject_del) is
>>> separate from object destruction (kobject_put).
>>>
>>> Fixes: 581cf833cac4 ("block: rnbd: add .release to rnbd_dev_ktype")
>>> Signed-off-by: Chaitanya Kulkarni<ckulkarnilinux@gmail.com>
>> lgtm, thx for the fix.
>> Acked-by: Jack Wang<jinpu.wang@ionos.com>
>
> If this is correct we will needs reviewed-by tag to apply this patch.
Eh no, that is not correct. What I care about is that it has been
seen and acknowledged. Whether it's a acked-by or reviewed-by
doesn't matter one single bit.
--
Jens Axboe
next prev parent reply other threads:[~2026-01-15 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 23:19 [PATCH] rnbd-clt: fix refcount underflow in device unmap path Chaitanya Kulkarni
2026-01-14 8:40 ` Jinpu Wang
2026-01-15 1:58 ` Chaitanya Kulkarni
2026-01-15 5:39 ` Jinpu Wang
2026-01-15 14:20 ` Jens Axboe [this message]
2026-01-15 14:22 ` Jens Axboe
2026-01-27 7:06 ` Shinichiro Kawasaki
2026-01-28 0:21 ` Chaitanya Kulkarni
2026-01-28 4:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fd9926-4e67-4396-ba84-c9749a9c7d1c@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=ckulkarnilinux@gmail.com \
--cc=grzegorz.prajsner@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox