From: Jens Axboe <axboe@kernel.dk>
To: Sagi Grimberg <sagi@grimberg.me>,
Max Gurtovoy <maxg@mellanox.com>,
linux-block@vger.kernel.org, martin.petersen@oracle.com,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
hch@lst.de
Cc: shlomin@mellanox.com, israelr@mellanox.com
Subject: Re: [PATCH 1/4] block: centrelize PI remapping logic to the block layer
Date: Tue, 3 Sep 2019 13:21:59 -0600 [thread overview]
Message-ID: <e9e36b41-f262-e825-15dc-aecadb44cf85@kernel.dk> (raw)
In-Reply-To: <8df57b71-9404-904d-7abd-587942814039@grimberg.me>
On 9/3/19 1:11 PM, Sagi Grimberg wrote:
>
>> + if (blk_integrity_rq(req) && req_op(req) == REQ_OP_READ &&
>> + error == BLK_STS_OK)
>> + t10_pi_complete(req,
>> + nr_bytes / queue_logical_block_size(req->q));
>> +
>
> div in this path? better to use >> ilog2(block_size).
>
> Also, would be better to have a wrapper in place like:
>
> static inline unsigned short blk_integrity_interval(struct request *rq)
> {
> return queue_logical_block_size(rq->q);
> }
If it's a hot path thing that matters, I'd strongly suggest to add
a queue block size shift instead.
--
Jens Axboe
next prev parent reply other threads:[~2019-09-03 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:14 [PATCH 1/4] block: centrelize PI remapping logic to the block layer Max Gurtovoy
2019-09-03 15:14 ` [PATCH 2/4] nvme-rdma: simplify error flow in nvme_rdma_queue_rq Max Gurtovoy
2019-09-04 5:51 ` Christoph Hellwig
2019-09-03 15:14 ` [PATCH 3/4] nvme-tcp: introduce nvme_tcp_complete_rq callback Max Gurtovoy
2019-09-03 19:15 ` Sagi Grimberg
2019-09-04 5:54 ` Christoph Hellwig
2019-09-04 9:02 ` Max Gurtovoy
2019-09-03 15:14 ` [PATCH 4/4] nvmet-loop: fix possible leakage during error flow Max Gurtovoy
2019-09-04 5:50 ` Christoph Hellwig
2019-09-03 19:11 ` [PATCH 1/4] block: centrelize PI remapping logic to the block layer Sagi Grimberg
2019-09-03 19:21 ` Jens Axboe [this message]
2019-09-04 5:49 ` Christoph Hellwig
2019-09-04 8:32 ` Max Gurtovoy
2019-09-04 12:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9e36b41-f262-e825-15dc-aecadb44cf85@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).