From: Tianxianting <tian.xianting@h3c.com>
To: Bart Van Assche <bvanassche@acm.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()
Date: Mon, 28 Sep 2020 14:56:18 +0000 [thread overview]
Message-ID: <ea21af15c4234608b630b5b679826227@h3c.com> (raw)
In-Reply-To: <b884d4af-ef49-f294-4099-e35778f2a783@acm.org>
Thank you Bart Van
Hi Jens,
Whether this version patch is ok for you?
Looking forward to your further comments :)
-----Original Message-----
From: Bart Van Assche [mailto:bvanassche@acm.org]
Sent: Saturday, September 26, 2020 12:07 PM
To: tianxianting (RD) <tian.xianting@h3c.com>; axboe@kernel.dk
Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps()
On 2020-09-25 19:39, Xianting Tian wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c index
> b3d2785ee..62d152d03 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3256,9 +3256,11 @@ static int __blk_mq_alloc_rq_maps(struct
> blk_mq_tag_set *set) {
> int i;
>
> - for (i = 0; i < set->nr_hw_queues; i++)
> + for (i = 0; i < set->nr_hw_queues; i++) {
> if (!__blk_mq_alloc_map_and_request(set, i))
> goto out_unwind;
> + cond_resched();
> + }
>
> return 0;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2020-09-28 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 2:39 [PATCH] [v3] blk-mq: add cond_resched() in __blk_mq_alloc_rq_maps() Xianting Tian
2020-09-26 4:07 ` Bart Van Assche
2020-09-28 14:56 ` Tianxianting [this message]
2020-09-28 15:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea21af15c4234608b630b5b679826227@h3c.com \
--to=tian.xianting@h3c.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox