From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH for-next v3] null_blk: add configfs variable shared_tags
Date: Tue, 30 Jan 2024 07:49:47 +0000 [thread overview]
Message-ID: <ea97f700-45b5-446c-b58e-b77c896deb46@nvidia.com> (raw)
In-Reply-To: <20240130042134.2463659-1-shinichiro.kawasaki@wdc.com>
On 1/29/2024 8:21 PM, Shin'ichiro Kawasaki wrote:
> Allow setting shared_tags through configfs, which could only be set as a
> module parameter. For that purpose, delay tag_set initialization from
> null_init() to null_add_dev(). Refer tag_set.ops as the flag to check if
> tag_set is initialized or not.
>
> The following parameters can not be set through configfs yet:
>
> timeout
> requeue
> init_hctx
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
I believe it is passing shared tag blktests, with that it looks good to
me.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-01-30 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 4:21 [PATCH for-next v3] null_blk: add configfs variable shared_tags Shin'ichiro Kawasaki
2024-01-30 7:49 ` Chaitanya Kulkarni [this message]
2024-01-30 8:27 ` Shinichiro Kawasaki
2024-02-08 18:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea97f700-45b5-446c-b58e-b77c896deb46@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox