From: Xiubo Li <xiubli@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, josef@toxicpanda.com
Cc: mchristi@redhat.com, hch@infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v3 0/2] blk-mq: Avoid memory reclaim when allocating
Date: Wed, 18 Sep 2019 06:54:40 +0800 [thread overview]
Message-ID: <eaa4fb45-3a62-839e-bdcf-5219fe1c8211@redhat.com> (raw)
In-Reply-To: <426aa779-1011-5a75-bb73-ae573c229806@kernel.dk>
On 2019/9/17 22:13, Jens Axboe wrote:
> On 9/17/19 6:09 AM, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Changed in V2:
>> - Addressed the comment from Ming Lei, thanks.
>>
>> Changed in V3:
>> - Switch to memalloc_noio_save/restore from Christoph's comment, thanks.
> This now seems to be a mix of both approaches, which I don't think makes
> sense at all. I think we should just stick to the gfp_t being passed in,
> and defining the standard mask for init time blk-mq memory allocations.
>
Hmm, I might missed or misunderstand from the last thread. In this
thread with the save/store, the GFP_KERNEL is using instead. Maybe
save/store pair is not a exactly correct place or occasion to use here
as @Bart mentioned.
Thanks.
BRs
next prev parent reply other threads:[~2019-09-17 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 12:09 [PATCH v3 0/2] blk-mq: Avoid memory reclaim when allocating xiubli
2019-09-17 12:09 ` [PATCH v3 1/2] blk-mq: Avoid memory reclaim when allocating request map xiubli
2019-09-17 12:09 ` [PATCH v3 2/2] blk-mq: use BLK_MQ_GFP_FLAGS and memalloc_noio_save/restore instead xiubli
2019-09-17 14:13 ` [PATCH v3 0/2] blk-mq: Avoid memory reclaim when allocating Jens Axboe
2019-09-17 22:54 ` Xiubo Li [this message]
2019-09-17 23:11 ` Jens Axboe
2019-09-17 23:19 ` Xiubo Li
2019-09-17 23:25 ` Jens Axboe
2019-09-17 23:30 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa4fb45-3a62-839e-bdcf-5219fe1c8211@redhat.com \
--to=xiubli@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox