From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Oleksandr Natalenko <oleksandr@natalenko.name>
Subject: Re: [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible
Date: Mon, 9 Aug 2021 20:55:16 -0600 [thread overview]
Message-ID: <eabcef59-64a1-6e6e-adbd-5924fabf9810@kernel.dk> (raw)
In-Reply-To: <YRHoxGKjD9JHjiXh@T590>
On 8/9/21 8:47 PM, Ming Lei wrote:
> On Mon, Aug 09, 2021 at 02:36:25PM -0600, Jens Axboe wrote:
>> On 8/4/21 9:35 PM, Ming Lei wrote:
>>> On Thu, Jul 29, 2021 at 11:42:26AM +0800, Ming Lei wrote:
>>>> When merging one bio to request, if they are discard IO and the queue
>>>> supports multi-range discard, we need to return ELEVATOR_DISCARD_MERGE
>>>> because both block core and related drivers(nvme, virtio-blk) doesn't
>>>> handle mixed discard io merge(traditional IO merge together with
>>>> discard merge) well.
>>>>
>>>> Fix the issue by returning ELEVATOR_DISCARD_MERGE in this situation,
>>>> so both blk-mq and drivers just need to handle multi-range discard.
>>>>
>>>> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
>>>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
>>>
>>> Hello Jens and Guys,
>>>
>>> Ping...
>>
>> Since this isn't a new regression this release and since this kind
>> of change always makes me a bit nervous, any objections to queueing
>> it up for 5.15 with the stable/fixes tags?
>
> Fine, will post a new version with fixes tag.
Sorry if I wasn't clear, I mean are you fine with queueing this for
5.15? I already did add the fixes tag.
--
Jens Axboe
next prev parent reply other threads:[~2021-08-10 2:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 3:42 [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible Ming Lei
2021-07-29 7:17 ` Oleksandr Natalenko
2021-07-29 9:18 ` Ming Lei
2021-08-05 3:35 ` Ming Lei
2021-08-09 20:30 ` Oleksandr Natalenko
2021-08-09 20:36 ` Jens Axboe
2021-08-10 2:47 ` Ming Lei
2021-08-10 2:55 ` Jens Axboe [this message]
2021-08-10 3:28 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2022-05-21 18:56 Gwendal Grignou
2022-05-23 15:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabcef59-64a1-6e6e-adbd-5924fabf9810@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).