From: Jens Axboe <axboe@kernel.dk>
To: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: improve error checking in blkdev_bio_end_io_async()
Date: Tue, 19 Oct 2021 13:05:42 -0600 [thread overview]
Message-ID: <eb5f3cf7-4bf3-d7f3-ed7f-cf067410f31b@kernel.dk> (raw)
In-Reply-To: <69df4731-3232-eb2a-664d-47d0db381843@kernel.dk>
On 10/19/21 12:59 PM, Jens Axboe wrote:
> Track the current error status of the dio with DIO_ERROR in the flags,
> which can then avoid diving into dio->bio for the fast path of not
> having any errors. This reduces the overhead of the function nicely,
> which was previously dominated by this seemingly cheap check:
>
> 4.55% -1.13% [kernel.vmlinux] [k] blkdev_bio_end_io_async
Disregard, ended up being an older test version. I'll send the right
one.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-19 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 18:59 [PATCH] block: improve error checking in blkdev_bio_end_io_async() Jens Axboe
2021-10-19 19:05 ` Jens Axboe [this message]
2021-10-19 19:06 ` Pavel Begunkov
2021-10-19 19:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5f3cf7-4bf3-d7f3-ed7f-cf067410f31b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox