public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Liu Bo <bo.liu@linux.alibaba.com>, linux-block@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 1/3] blk-iolatency: fix IO hang due to negative inflight counter
Date: Fri, 25 Jan 2019 09:30:49 +0100	[thread overview]
Message-ID: <eb65005a-572d-1640-3c85-214be541a348@suse.de> (raw)
In-Reply-To: <20190125001249.72688-2-bo.liu@linux.alibaba.com>

On 25/01/2019 01:12, Liu Bo wrote:
> In fact the hang can be easily reproduced by the below script,
> 
> H=/sys/fs/cgroup/unified/
> P=/sys/fs/cgroup/unified/test
> 
> echo "+io" > $H/cgroup.subtree_control
> mkdir -p $P
> 
> echo $$ > $P/cgroup.procs
> 
> xfs_io -f -d -c "pwrite 0 4k" /dev/sdg
> 
> echo "`cat /sys/block/sdg/dev` target=1000000" > $P/io.latency
> 
> xfs_io -f -d -c "pwrite 0 4k" /dev/sdg

Can you please turn this into a testcase for blktests as well?

Thanks,
	Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2019-01-25  8:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25  0:12 [PATCH v2 0/3] iolatency bug fix Liu Bo
2019-01-25  0:12 ` [PATCH v2 1/3] blk-iolatency: fix IO hang due to negative inflight counter Liu Bo
2019-01-25  8:30   ` Johannes Thumshirn [this message]
2019-01-29 23:55     ` Liu Bo
2019-01-25  0:12 ` [PATCH v2 2/3] Blk-iolatency: warn on negative inflight IO counter Liu Bo
2019-01-25  0:12 ` [PATCH v2 3/3] blk-mq: remove duplicated definition of blk_mq_freeze_queue Liu Bo
2019-02-08 19:14 ` [PATCH v2 0/3] iolatency bug fix Liu Bo
2019-02-08 19:42 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb65005a-572d-1640-3c85-214be541a348@suse.de \
    --to=jthumshirn@suse.de \
    --cc=axboe@kernel.dk \
    --cc=bo.liu@linux.alibaba.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox