From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F14B264636 for ; Fri, 26 Dec 2025 20:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766782097; cv=none; b=sIx2LOM0AArHs9CVqvtb0IZpnVkXkgw0QWuRh5RAh9koz8nQiMvq0tnMcp8BiTSzlzvifBy+TCHZrG/5qZD83bbRARLsvZ5lI4FFfjc4w/4va4t9YZra/LwieqZQG7ooaZL/pCgLXjF9Mz9RL49irmPcnrxvdb+Zr/nTefopges= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766782097; c=relaxed/simple; bh=EAgJ3664AENbLI1S3Tf4CRT9521EaZ0GR7ptn4Sh+c8=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=MAkWXhHcJaRkvzw35GLJzt5D7kMVDpoGMUcIEn842esaQFoMD0kaVFfItyomHxcC5TubhmNH+w1HYPmSl7JRNkj00hvrZvszuLVxNjg5t92Tw9OFfagNJyVdplyPa5DnefMN+Javq5sPG/lpr6s4TKDaD3sSpe9aJL7JsL0dOkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DLnarn3B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=H7xOBbyA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DLnarn3B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="H7xOBbyA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766782095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=DLnarn3BH+CkNjBqtnA4PlfQa2pRx452LmsR2yKVfImPgEWqREbr90ajKcY+7/81nTjaDA uL+/JfbW+rt0XYmrcJynRB2/Mok5Kw55llN1KMU6PBvuigJAdO2QqZLNDCI87cp1gBSFka eHeFdnrh48aRDOfXAN2vcOgsNle5H8A= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-JxjRBYDzNzydX4zeRqiWYg-1; Fri, 26 Dec 2025 15:48:13 -0500 X-MC-Unique: JxjRBYDzNzydX4zeRqiWYg-1 X-Mimecast-MFC-AGG-ID: JxjRBYDzNzydX4zeRqiWYg_1766782093 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8bbe16e0a34so1828357285a.1 for ; Fri, 26 Dec 2025 12:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766782093; x=1767386893; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=H7xOBbyAuo5hdzdfuFjgFSJZ4hdKURvGi1NPWv40M2tg6NlRjrmsFbHhMw3tV5nkjw 21MC7Yrw3tHLZ9VmUgdyhh7hSvxfxxARpwh+Uk8DJ8DLI7iZx13FAJiE1e9M/95u1U2l qwsFbPosRAUX8mrJnU1url6puTKNAhsEHKaJ/4wi5nJLcnwwZxIJxlM12HwnJvDVHQR1 P6O+1UFWitXQs6PvpkWFB0fxv3TvnT85XCvsEX+WMSClu2r5X2i1UPfdqeADLY1ic7nJ p4LDV7zr7XJ23AbLXSIBuuqyzg+DbchTq/ExVWX+NyII7irnnSJ6v5Fzxag8rCGzn0SK pG8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766782093; x=1767386893; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=YWCOur0zIkSacrswpnuVZq+YQbAph0MlfZD6y7NmzNjKqRoGF698G/dEKSL+TPk87n qgRHcjKnFYNuoGxQZoW/q3uXbRTDYTUa/WFR6WrCKhia8+UjHNydINLKLAfAKY68Nnk2 FLzR11f1eo8xKuQk5PI/zG9l1iI5FtEGkq+DDe3pvXRRq7Bd7nC2ZT+ZNZyx0HKjVbLa r8cmQHved3b6JHR7ZFFC9IBXpoGe5ADJhXUckmXHKF54KTnPylkj4/ZGe/LrbEdeMyaX B0xhoOSUa3Pjt6xION7gg0csr6p8K5oDNYJQtnXAHdzbMAxSeRS1qIPL8R6A/V+YlkA6 XHDQ== X-Forwarded-Encrypted: i=1; AJvYcCU3c0KSTFZ5ILAuWcH0ARBqe19ve8bO04GsFQLE/hIPdXxTbd4le9i+ZCznLPZRRphnO7JHgDdVeIOEBg==@vger.kernel.org X-Gm-Message-State: AOJu0YzfPmpAWW8URQ5BTNz9oVLx2TptAcNc7xvxF/tvF2PhbEb+rTA+ iR8ZfQUXCVY+E7EOHHiSFJYkovA86dmdUIA4WUNYG2amS3/SrE1iUJVXuPEj+h16mzPKrWgjI2A gZLGFEL0MXX3bRLZkCav9GDFpmBqKyPOdFNOhSBRjDpGWwFwh6lry5yGYNegCa21R X-Gm-Gg: AY/fxX4gqa34kPY61AoYcyQtxkup4DHVEFwEwwfnBVdydJpYmmusXrugK/1OU/KJJGh gLU90HZAEuRLgB/+5/8RpKJ0GT/Fln0inyE6Ea5zOQTSVnJebr6sYSWgsORfGpzvrllmSRVij1U J+XHDDOjk9TN2DZ0AnjcSN3Fj69wqwRNdh2xhrThFwAW/gQ7wjGqnesyrDxP8yqPIJCsDnGIfPS 8oFP2E9Ro0t0C7v6BXaaF5l8ySrjPNhe/cLGbXJE76cGyjVvbScK0ZwimIEmKBe51BDENcQL49O 7989W6//No/QMbS7qBfCiKhZVs+vCd0BfsWzEQJ4FluQoNfu+tdbEQqTt3h2zMr//rZGndD9SHp M92+pKQVZKGMTXIbw7i/lFfgy2aXNr1KJkYTqMNAA6whqBtfyiz5/LCNP X-Received: by 2002:a05:620a:4450:b0:8b2:f5b5:c9bf with SMTP id af79cd13be357-8bee76c8ecdmr4098092185a.22.1766782093306; Fri, 26 Dec 2025 12:48:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5vt35jXazmAlmHnLRQK7CDf0928bdO3E07iE5exs1VnuKt+dhmYfT9Sq8ULHkPw+Z5ZFmhA== X-Received: by 2002:a05:620a:4450:b0:8b2:f5b5:c9bf with SMTP id af79cd13be357-8bee76c8ecdmr4098087085a.22.1766782092880; Fri, 26 Dec 2025 12:48:12 -0800 (PST) Received: from ?IPV6:2601:600:947f:f020:85dc:d2b2:c5ee:e3c4? ([2601:600:947f:f020:85dc:d2b2:c5ee:e3c4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d96ce4e23sm205030136d6.19.2025.12.26.12.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Dec 2025 12:48:12 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Fri, 26 Dec 2025 15:48:08 -0500 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/33] cpuset: Remove cpuset_cpu_is_isolated() To: Frederic Weisbecker , LKML Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org References: <20251224134520.33231-1-frederic@kernel.org> <20251224134520.33231-22-frederic@kernel.org> Content-Language: en-US In-Reply-To: <20251224134520.33231-22-frederic@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/24/25 8:45 AM, Frederic Weisbecker wrote: > The set of cpuset isolated CPUs is now included in HK_TYPE_DOMAIN > housekeeping cpumask. There is no usecase left interested in just > checking what is isolated by cpuset and not by the isolcpus= kernel > boot parameter. > > Signed-off-by: Frederic Weisbecker > --- > include/linux/cpuset.h | 6 ------ > include/linux/sched/isolation.h | 4 +--- > kernel/cgroup/cpuset.c | 12 ------------ > 3 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 1c49ffd2ca9b..a4aa2f1767d0 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -79,7 +79,6 @@ extern void cpuset_unlock(void); > extern void cpuset_cpus_allowed_locked(struct task_struct *p, struct cpumask *mask); > extern void cpuset_cpus_allowed(struct task_struct *p, struct cpumask *mask); > extern bool cpuset_cpus_allowed_fallback(struct task_struct *p); > -extern bool cpuset_cpu_is_isolated(int cpu); > extern nodemask_t cpuset_mems_allowed(struct task_struct *p); > #define cpuset_current_mems_allowed (current->mems_allowed) > void cpuset_init_current_mems_allowed(void); > @@ -215,11 +214,6 @@ static inline bool cpuset_cpus_allowed_fallback(struct task_struct *p) > return false; > } > > -static inline bool cpuset_cpu_is_isolated(int cpu) > -{ > - return false; > -} > - > static inline nodemask_t cpuset_mems_allowed(struct task_struct *p) > { > return node_possible_map; > diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h > index 6842a1ba4d13..19905adbb705 100644 > --- a/include/linux/sched/isolation.h > +++ b/include/linux/sched/isolation.h > @@ -2,7 +2,6 @@ > #define _LINUX_SCHED_ISOLATION_H > > #include > -#include > #include > #include > > @@ -84,8 +83,7 @@ static inline bool housekeeping_cpu(int cpu, enum hk_type type) > static inline bool cpu_is_isolated(int cpu) > { > return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) || > - !housekeeping_test_cpu(cpu, HK_TYPE_TICK) || > - cpuset_cpu_is_isolated(cpu); > + !housekeeping_test_cpu(cpu, HK_TYPE_TICK); > } > > #endif /* _LINUX_SCHED_ISOLATION_H */ > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 25ac6c98113c..cd6119c02beb 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1490,17 +1489,6 @@ static void update_isolation_cpumasks(void) > isolated_cpus_updating = false; > } > > -/** > - * cpuset_cpu_is_isolated - Check if the given CPU is isolated > - * @cpu: the CPU number to be checked > - * Return: true if CPU is used in an isolated partition, false otherwise > - */ > -bool cpuset_cpu_is_isolated(int cpu) > -{ > - return cpumask_test_cpu(cpu, isolated_cpus); > -} > -EXPORT_SYMBOL_GPL(cpuset_cpu_is_isolated); > - > /** > * rm_siblings_excl_cpus - Remove exclusive CPUs that are used by sibling cpusets > * @parent: Parent cpuset containing all siblings Reviewed-by: Waiman Long