From: Nilay Shroff <nilay@linux.ibm.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: shinichiro.kawasaki@wdc.com, chaitanyak@nvidia.com,
kbusch@kernel.org, sagi@grimberg.me, hch@lst.de,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
venkat88@linux.vnet.ibm.com, sachinp@linux.vnet.ibm.com,
gjoyce@linux.ibm.com
Subject: Re: [PATCHv4 blktests] nvme: add test for creating/deleting file-ns
Date: Thu, 20 Jun 2024 12:10:32 +0530 [thread overview]
Message-ID: <ec685e52-0ea9-4928-8b96-4ba503e8664b@linux.ibm.com> (raw)
In-Reply-To: <rxeyn6susgjlguqg3jk7ntthjvhn6gt3meu4dcb5kchynz3b2e@uznnvlner6ri>
On 6/20/24 12:05, Daniel Wagner wrote:
> On Wed, Jun 19, 2024 at 10:55:02PM GMT, Nilay Shroff wrote:
>> + truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
>> + uuid="$(uuidgen -r)"
>
> This adds a new dependency on an external tool. It should be mentioned
> in the README and added to the list of tools to check for:
> _check_dependencies(). Alternatively you could skip the test if the tool
> is not available. Anyway the rest looks good.
>
The "uuidgen" is part of util-linux package and I saw that it's already mentioned
as one of the required packages for blktest: https://github.com/osandov/blktests
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
Thanks,
--Nilay
next prev parent reply other threads:[~2024-06-20 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 17:25 [PATCHv4 blktests] nvme: add test for creating/deleting file-ns Nilay Shroff
2024-06-20 6:35 ` Daniel Wagner
2024-06-20 6:40 ` Nilay Shroff [this message]
2024-06-20 6:55 ` Daniel Wagner
2024-06-20 8:28 ` Venkat Rao Bagalkote
2024-06-24 3:04 ` Chaitanya Kulkarni
2024-06-24 7:57 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec685e52-0ea9-4928-8b96-4ba503e8664b@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox