Re: [PATCH] block: simplify blk_mq_finish_request()

[Damien Le Moal <dlemoal@kernel.org>]

On 2/25/26 07:16, Jens Axboe wrote:
> On 2/24/26 2:58 PM, Damien Le Moal wrote:
>> Remove the local q variable as it is not necessary. This also removes a
>> useless pointer dereference when RQF_USE_SCHED is not set for a request.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>> ---
>>  block/blk-mq.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/block/blk-mq.c b/block/blk-mq.c
>> index 9af8c3dec3f6..55a255750ad1 100644
>> --- a/block/blk-mq.c
>> +++ b/block/blk-mq.c
>> @@ -781,12 +781,10 @@ EXPORT_SYMBOL_GPL(blk_mq_alloc_request_hctx);
>>  
>>  static void blk_mq_finish_request(struct request *rq)
>>  {
>> -	struct request_queue *q = rq->q;
>> -
>>  	blk_zone_finish_request(rq);
>>  
>>  	if (rq->rq_flags & RQF_USE_SCHED) {
>> -		q->elevator->type->ops.finish_request(rq);
>> +		rq->q->elevator->type->ops.finish_request(rq);
>>  		/*
>>  		 * For postflush request that may need to be
>>  		 * completed twice, we should clear this flag
> 
> This will compile to the same code...

OK. I had not check the compiled code. Sorry for the noise.


-- 
Damien Le Moal
Western Digital Research