From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40273C433DF for ; Fri, 10 Jul 2020 14:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F190207D0 for ; Fri, 10 Jul 2020 14:00:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="pGdMddqx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgGJOAR (ORCPT ); Fri, 10 Jul 2020 10:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726820AbgGJOAR (ORCPT ); Fri, 10 Jul 2020 10:00:17 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BAE9C08C5CE for ; Fri, 10 Jul 2020 07:00:17 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id q74so6128264iod.1 for ; Fri, 10 Jul 2020 07:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PvFFjq5d2hTh/8bud3isCUm9zau1JSIuUDHz07eccEY=; b=pGdMddqxUAmlcCo7ogE0OCAZvDGeFPItZ1LDAQmz8UIaq7nRQ2ktMWmXfsjfMQQCvi eh4tmKgY3KMq4jKHpglluCnjKQO0+g34gmBYfOt1LrZCt3xVszxoSx1Il/aPI2ix57Oa Vj32TJnOLGYkQyVePcQluxBs5jl+0cFj4KKeXG2N40NxDI3oMrAb/1Djm7F9CN8Oj6i4 B4yyWVA8Vwpc6MuGuodL4plOShU8gmPNyqvFo/7wYRoyywlPdXaPWKNvEkn8oGFpB52R +izO7i1tBYFgAAe5OCDArRCD35lIvi8XDmP/4p2N1WSubo3rgy3+Wj9K+8oTMSgQmPBz 2Vcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PvFFjq5d2hTh/8bud3isCUm9zau1JSIuUDHz07eccEY=; b=nkrvIhavalTuyvBT/egu5VoP5nnTHfYuzXZD/IUZn2wb1F8IBGYMOto7k8+Q9hsH2M JYY42x2qHdgUIU6AZaVtDV7S4zpY1qrRRhqjSGOGm1iRp5+lScciBXB3Dg/dmCmDDNSC b1HM3Gdl7p0cJwmdjxhw0lgLz1GgvIYXGjVSjk1ESaB+m9Tx26opQ6NiEE4boFzrK30y 2ZViXN7bsyCpKjS/vfK1QSDnLH+7z1RKP4abuRPmB/r5ncujs3umzKUusuOfsAhZyNbz fyoBGZ2piveBrJzgUFxPS71znK6ZPW+ZVi/Pu7dwHtFuWgxZUtZJChjz1HUWZBj88qPG 7XrA== X-Gm-Message-State: AOAM531NvSfq47muoQ/Z5nR/oqaE6VwFuTFQj3hdD9C0GDgVQuZlcn+B veIm2xStuztZqBKTmLS2i1TIjA== X-Google-Smtp-Source: ABdhPJw2NckfkJzMQc16hE0YTUMLHE0WQtJPPNmrEX8HPgeJ6vFTo3Z869Z78VJq7eAbTVrxys316w== X-Received: by 2002:a5d:97d9:: with SMTP id k25mr47749067ios.42.1594389616361; Fri, 10 Jul 2020 07:00:16 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id w15sm3650008ila.65.2020.07.10.07.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 07:00:15 -0700 (PDT) Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed_request() To: Baolin Wang Cc: ming.lei@redhat.com, baolin.wang7@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com> From: Jens Axboe Message-ID: Date: Fri, 10 Jul 2020 08:00:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <969d0e9f637b2a0dbfb3d284abfbed6fc7665ea4.1593846855.git.baolin.wang7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 7/4/20 1:28 AM, Baolin Wang wrote: > We've already validated the 'q->elevator' before calling ->ops.completed_request() > in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again, > and remove it. Applied, but I reformatted and edited your commit message. -- Jens Axboe