From: Avi Kivity <avi@scylladb.com>
To: Coly Li <colyli@suse.de>, Shaohua Li <shli@kernel.org>
Cc: NeilBrown <neilb@suse.com>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: raid0 vs. mkfs
Date: Thu, 29 Jun 2017 18:15:43 +0300 [thread overview]
Message-ID: <eeae1d04-8c92-c511-8977-5124735646c4@scylladb.com> (raw)
In-Reply-To: <c384d070-457c-cfee-e35f-53b9195ace10@suse.de>
On 12/08/2016 06:44 PM, Coly Li wrote:
> On 2016/12/8 上午12:59, Shaohua Li wrote:
>> On Wed, Dec 07, 2016 at 07:50:33PM +0800, Coly Li wrote:
> [snip]
>> Thanks for doing this, Coly! For raid0, this totally makes sense. The raid0
>> zones make things a little complicated though. I just had a brief look of your
>> proposed patch, which looks really complicated. I'd suggest something like
>> this:
>> 1. split the bio according to zone boundary.
>> 2. handle the splitted bio. since the bio is within zone range, calculating
>> the start and end sector for each rdev should be easy.
>>
> Hi Shaohua,
>
> Thanks for your suggestion! I try to modify the code by your suggestion,
> it is even more hard to make the code that way ...
>
> Because even split bios for each zone, all the corner cases still exist
> and should be taken care in every zoon. The code will be more complicated.
>
Hi Coly,
Did you manage to complete this patch? We are seeing its effect, not
only with mkfs, but also with fstrim(8).
Avi
next prev parent reply other threads:[~2017-06-29 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56c83c4e-d451-07e5-88e2-40b085d8681c@scylladb.com>
[not found] ` <87oa108a1x.fsf@notabene.neil.brown.name>
[not found] ` <286a5fc1-eda3-0421-a88e-b03c09403259@scylladb.com>
[not found] ` <87inr880au.fsf@notabene.neil.brown.name>
[not found] ` <df73ebc4-9b78-09b5-022b-089c30dea17c@scylladb.com>
[not found] ` <87d1he7zv9.fsf@notabene.neil.brown.name>
[not found] ` <33bb250a-4dfd-0acc-9958-30fdac10918c@scylladb.com>
2016-12-07 11:50 ` raid0 vs. mkfs Coly Li
2016-12-07 12:03 ` Coly Li
2016-12-07 16:59 ` Shaohua Li
2016-12-08 16:44 ` Coly Li
2016-12-08 19:19 ` Shaohua Li
2016-12-09 7:34 ` Coly Li
2016-12-12 3:17 ` NeilBrown
2017-06-29 15:15 ` Avi Kivity [this message]
2017-06-29 15:31 ` Coly Li
2017-06-29 15:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeae1d04-8c92-c511-8977-5124735646c4@scylladb.com \
--to=avi@scylladb.com \
--cc=colyli@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox