Re: [PATCH 1/1] block: optimise in irq bio put caching

Christoph Hellwig
2024-01-29T17:24:07Z

On Mon, Jan 29, 2024 at 02:36:57PM +0000, Pavel Begunkov wrote:
> Let me know if there are any concerns with the patch

This seems to lose the case where non-polled bios are freed
form process context, which can be true with threadead interrupts
or various block remappers that defer I/O completions to workqueues,
and also a lot of file systems (but currentl the alloc cache isn't
used by file systems).

Also jumping backward for non-loop code flow is a nasty pattern.