From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2085FC433EF for ; Wed, 3 Nov 2021 19:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED93060EBC for ; Wed, 3 Nov 2021 19:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbhKCT7L (ORCPT ); Wed, 3 Nov 2021 15:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbhKCT7H (ORCPT ); Wed, 3 Nov 2021 15:59:07 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2D1FC06120F for ; Wed, 3 Nov 2021 12:56:30 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id v40-20020a056830092800b0055591caa9c6so5111387ott.4 for ; Wed, 03 Nov 2021 12:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TuTvA2VFldo5bKpIsQIYkfQTcqu/XUpeO+ZJ0o08srE=; b=Kc8JPw+Qw4syw39DvCFAkRFc5WtVBGeDV5KtRwWrl0nAo3ukcKEGX0JNPykLf0qpfx Qtx22OiLajageqDIjzdNeIIb07E4fDhKWMAjYJbE5Jmm+1F5bKW93Txpyz0JuUnohPRE GE3UEeEQiAr5D5b7RSd4Yp+FYUAFz4WR9be+pPc14cn/a01nloyJFiq6L9PW7jnPVXkk Xok+mMAlMsjyxEB9CA2RZQt4IfEftkY/0RqtzLOe+zbPta+iNyyF3JmoP0IVlTT+FSfH OGJhr922EJ40Zl3aKElIg4wtIZeBOHCeEsTkxiWNnd9+7IzEqt3jCcqkm3sCrqbIYxVI 8WjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TuTvA2VFldo5bKpIsQIYkfQTcqu/XUpeO+ZJ0o08srE=; b=QBE9bngsJ5qqePLrWIicCyPNu3rJKB2D1OWOz86uaQ29uw2dN80PiIqS9xI8b6LTcT IeHSXppuTVIuWZFy3iNnoVPjx/ivF8xbwTmP8e4W3oV2J5FMeeBkX4EJEOfVUwWgoxrs uxpE/zyV81IPl9fLwC1Pek+w8iaJnJoGugRmMU6062wRJ3Tzv481hgTqOQ+IGV9BBrxl 99ew/7XOT7GH3bF3s1CL8MH84JjamyELX93FblT+V6muzAzPzTs9FLGE7ieg/nkmZRQQ GZDRzfjcDEXch+yhie7vKYMPC8jfN/9hlrBO4+SloEVcwsA9m5OG+eh/HUiC3D2ljlBj +ULg== X-Gm-Message-State: AOAM532w5ak62RP1+H2OAlKbRFSBx0NCKS3D4iLuzXQGi3GZ1IFVArJL 8032CS940Y/TI3Lwf9RI+iFG/g== X-Google-Smtp-Source: ABdhPJxZAUHsHE+0bvOdtD3JkKcJuO8LDLO+Hz6J+nPiBBZWkwAOQI9WRgQ/AfNVGJ8qdhntnN2pSQ== X-Received: by 2002:a05:6830:43aa:: with SMTP id s42mr16579659otv.13.1635969390149; Wed, 03 Nov 2021 12:56:30 -0700 (PDT) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id z12sm23945oid.45.2021.11.03.12.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Nov 2021 12:56:29 -0700 (PDT) Subject: Re: [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data To: Guenter Roeck Cc: linux-block@vger.kernel.org, Naresh Kamboju , linux-kernel@vger.kernel.org References: <20211019153300.623322-1-axboe@kernel.dk> <20211019153300.623322-2-axboe@kernel.dk> <20211103195411.GA3156469@roeck-us.net> From: Jens Axboe Message-ID: Date: Wed, 3 Nov 2021 13:56:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211103195411.GA3156469@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/3/21 1:54 PM, Guenter Roeck wrote: > Hi, > > On Tue, Oct 19, 2021 at 09:32:57AM -0600, Jens Axboe wrote: >> There's a hole here we can use, and it's faster to set this earlier >> rather than need to check q->elevator multiple times. >> >> Signed-off-by: Jens Axboe > > This patch results in a warning backtrace with one of my qemu > boot tests. Should be fixed in the current tree, will go out soonish. If you have time, can you pull in: git://git.kernel.dk/linux-block for-next into -git and see if it fixes it for you? -- Jens Axboe