From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 778C5C33C9E for ; Sat, 1 Feb 2020 04:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 480B3206D3 for ; Sat, 1 Feb 2020 04:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="HBZz1k+W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbgBAEsw (ORCPT ); Fri, 31 Jan 2020 23:48:52 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44714 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726772AbgBAEsv (ORCPT ); Fri, 31 Jan 2020 23:48:51 -0500 Received: by mail-pg1-f193.google.com with SMTP id x7so4665837pgl.11 for ; Fri, 31 Jan 2020 20:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SDiRJgIexvsCRZyBGBkTLxhYXwLjtWjl6c8nsRIE3KI=; b=HBZz1k+Wprky9UL45iCfSEdfdTFJ3ZF6QhbNruPR0fUAbcYvUerrtVj7qkTM047lft 8BElWoGLtA/lNBXCt2J+ks/ph1k2Hza6tplCjFwGcM7mZUho5XfOjlqFoS2o1H8gXket Yw8F9ap1aqe7PZ3c6pAyyrawdUZe/SMbgOy3gKMW+uAtVh5qnnljKK2L7Qf0IOqCcMHT xyUHKX3uyc6rGLHboDxnhFAR8iwpzBDOlLjeO3fq5lokQqHMloU+yqA1Wcy3+8M+1Fz4 tadcu2Ak1t5pgBFPxY/E75URx36YERI4lJeXY+UMEsXL+zuU3VLOvBk9sjipG5/yh7D9 hAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SDiRJgIexvsCRZyBGBkTLxhYXwLjtWjl6c8nsRIE3KI=; b=osJ0P+jRha5ttRww64fAZZuIp6VaKAGznDcTTYpd1c9nvjDRlMQGYhaVVgra2PxOrJ xansjF/IjiFV62Ga4jQwQWLypmda9eJd2f5RFGe9ukdHPuuf9lRQjOJ9IBH42V6ODnYK 6L5Oi8scYukKT2YN7SBdX7Wv05uOi9lVUVCZ3yV6dVm4NCU6FfJdNB7jGcQfrJbiMpBY SwcDUlzLi0H+fyvXNZgQ1dWGYxsk/Fz0jU//IBC9iqGNLbyPdzpE0xp8xSYF60lhS35F Ew/a3tGQJiqeGiZDz4EGd+CRfuHuVEiIMw5U1EhvtPbujcZpywewRM91/VGyTLW6cJxG 4AvQ== X-Gm-Message-State: APjAAAWPOkrYfFX5wfcq2ttiRNRRqJkeeYDuHV8nYqrnb938Rrr0T3iH /iZUPop4auPWvxqc4xHCnD+kxw== X-Google-Smtp-Source: APXvYqxF2uIMQQW0jF0M5Zly1z9uI1Fu8uIiVzlx8pi0NCLvu3s+9xUFEpIh3UMBmTJssLHk0XfxsA== X-Received: by 2002:a63:f148:: with SMTP id o8mr14545058pgk.314.1580532530019; Fri, 31 Jan 2020 20:48:50 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id d24sm13108879pfq.75.2020.01.31.20.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 20:48:49 -0800 (PST) Subject: Re: [PATCH BUGFIX 0/6] block, bfq: series of fixes, and not only, for some recently reported issues To: Paolo Valente Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, patdung100@gmail.com, cevich@redhat.com References: <20200131092409.10867-1-paolo.valente@linaro.org> From: Jens Axboe Message-ID: Date: Fri, 31 Jan 2020 21:48:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200131092409.10867-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 1/31/20 2:24 AM, Paolo Valente wrote: > Hi Jens, > these patches are mostly fixes for the issues reported in [1, 2]. All > patches have been publicly tested in the dev version of BFQ. > > Thanks, > Paolo > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539 > [2] https://bugzilla.kernel.org/show_bug.cgi?id=205447 > > Paolo Valente (6): > block, bfq: do not plug I/O for bfq_queues with no proc refs > block, bfq: do not insert oom queue into position tree > block, bfq: get extra ref to prevent a queue from being freed during a > group move > block, bfq: extend incomplete name of field on_st > block, bfq: get a ref to a group when adding it to a service tree > block, bfq: clarify the goal of bfq_split_bfqq() > > block/bfq-cgroup.c | 12 ++++++++++-- > block/bfq-iosched.c | 20 +++++++++++++++++++- > block/bfq-iosched.h | 3 ++- > block/bfq-wf2q.c | 27 ++++++++++++++++++++++----- > 4 files changed, 53 insertions(+), 9 deletions(-) I wish some of these had been sent sooner, they really should have been sent in a few weeks ago. Just took a quick look at the bug reports, and at least one of the bugs mentions looks like it had a fix available 2 months ago. Have they been in -next? They are all marked as bug fixes, should they have stable tags? All of them, some of them? -- Jens Axboe