Re: [PATCH blktests v4 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

Shinichiro Kawasaki
2023-08-30T18:47:29Z

On Aug 30, 2023 / 11:20, Daniel Wagner wrote:
> Almost all fabric tests have the identically code for
> setting up and cleaning up the target side. Introduce
> two new helpers.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>

Thanks Daniel for this v4 series. All patches looks good, except one thing
in this patch.

[...]

> diff --git a/tests/nvme/018 b/tests/nvme/018
> index 68729c3cb070..19e439f3f3e0 100755
> --- a/tests/nvme/018
> +++ b/tests/nvme/018
> @@ -21,16 +21,9 @@ test() {
>
> _setup_nvmet
>
> - local port
> local nvmedev
>
> - truncate -s "${nvme_img_size}" "${def_file_path}"
> -
> - _create_nvmet_subsystem "${def_subsysnqn}" "${def_file_path}" \
> - "${def_subsys_uuid}"
> - port="$(_create_nvmet_port "${nvme_trtype}")"
> - _add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}"
> - _create_nvmet_host "${def_subsysnqn}" "${def_hostnqn}"
> + _nvmet_target_setup

As I noted for v3, I think the line above should be,

_nvmet_target_setup --blkdev file

If the change is ok for you, I'll add this fix up and apply the series.

>
> _nvme_connect_subsys "${nvme_trtype}" "${def_subsysnqn}"
>
> @@ -48,12 +41,7 @@ test() {
>
> _nvme_disconnect_subsys "${def_subsysnqn}"
>
> - _remove_nvmet_subsystem_from_port "${port}" "${def_subsysnqn}"
> - _remove_nvmet_subsystem "${def_subsysnqn}"
> - _remove_nvmet_port "${port}"
> - _remove_nvmet_host "${def_hostnqn}"
> -
> - rm "${def_file_path}"
> + _nvmet_target_cleanup
>
> echo "Test complete"
> }