Re: [PATCH blktests v4 0/3] Introduce nvmet target setup/cleanup helpers

Shinichiro Kawasaki
2023-08-31T02:25:28Z

On Aug 30, 2023 / 11:20, Daniel Wagner wrote:
> Updated the series according the last round of feedback and retested it. In
> order to pass the 'make check' check this version depends on the upcoming revert
> of 26664dff17b6 ("Do not suppress any shellcheck warnings") as discussed in the
> v3 thread.
>
> original cover letter:
>
> Introduce helpers to setup nvmet targets. This is spin off from the refactoring
> patches and the allowed_host patches [1].
>
> Sagi suggested to record all resources allocated by nvmet_target_setup and then
> later clean them up in nvmet_target_cleanup. I opted to figure out in
> nvmet_target_cleanup what was allocated via the newly introdcuded _get_nvmet_ports
> helper. The reason being, Hannes told me offline that he would like to add ANA
> tests which will add some more ports to the subsystem. I hope with this
> the code is more future proof.
>
> BTW, while looking at this I saw that the passthru code is using the awkward
> return value port when calling nvmet_passthru_target_setup. It seems some
> more refactoring is in order...
>
> [1] https://lore.kernel.org/linux-nvme/5h333eqhtw252sjw6axjewlb5bbb5ze7awekczxe3kie2lnhw6@manyer42khct/

I've applied the series with the fix noted for the 3rd patch. I also reverted
the commit 26664dff17b6 together. Thanks again for this clean up :)