From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEA75199243 for ; Fri, 14 Jun 2024 12:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368426; cv=none; b=KNRMhxzUNQPMx9m17cnHu5hIdLyGdXbwTOP1lPi0fOBLXxMVUi8g6SirvSiPF2zu1PC7qiKqLfWPABkQ3CFvrrcWXe3m0GSmAUVr6WA03JCZTnhEbkG7PB8WQuTlXbMeBPnxqtXFu7t/zbqopJekJ1J32bIuPVUZICQZ+bctrsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718368426; c=relaxed/simple; bh=ViOeFSLpzBTfbhkwvbIOhDLgIujUpX169FCRqiXsZHw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=goxGfTokzx522qhLAl6uH5u0TiSzDIgs1osJl1KGgQdfHGaFlai6w310PGGWyCP8Bj7WAzqZowi4AnWybqrCJ4K7HVoVa0de5g9huuSurQJf9Mg7crVK4pPKBrwc/3FtZEB7bVnPlGQc1qnl8+P4G9TsnWdGSXMVXwDyAdhSq/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=LuV9Yhz1; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="LuV9Yhz1" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f6f38b6278so1925445ad.0 for ; Fri, 14 Jun 2024 05:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718368424; x=1718973224; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IQUOxKnD6CsmHDQ8zwTblKdKo9rITBkMiMcIVKNHWq0=; b=LuV9Yhz17Xocu9NAHd9mQYpjvIl00VlVdGe7bRqWYO80L7X9/cHFM4n3N+EbTbLGaU cOOh+b0dIwTDYwTQ3u8NpufJ5hrX031r4f7Le4p+T5I5LS0N5chAfXGpWC3WJrygda3B 13x+3F9MNOrx153LZj9GWVI8nLwXQTV/wQBgQGaDdOPP1O7xXPj3YOxYN2AAfVTB15bo mdMNQyztKNqum/GqOIyJYh0vOND9T1Yt7qyGml6YnhqnszSaaEO9eWrnzxmOxS+VW+Qc t7enjwOUGTU/cToDlqMxAKZOlcHiB1nMcSPXgtWED2i6NvjqRb+zM2sZGxNXioN0OpWx w+RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718368424; x=1718973224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQUOxKnD6CsmHDQ8zwTblKdKo9rITBkMiMcIVKNHWq0=; b=kWrKg1k3BCRJWXDjRDiWiWkr/xTTc42sUYHBPMitzBzQaV/z6t2Ah4XL5UByuxH3i4 8wfOU8uNacybeomo+xIJQaGJiGalSmTVIg71eukP15qYwTHz15a2ex6b3EBHjCUIYE0B H5b1xtEs6leKrxH1vgQeQ/4n8GHUZkDG149+e6F3mPUfIKyir0uzpUSz8vtKLRlpq6dB fbe2MWhpB/0bR/NfrL2aHtWqnO3/R16nE+uexwdDHYfJfuEUi3QNTmoN0ROLyN5BtuMS WH3xOjSkAAFInbJcRP5AsmXh3db5fKrvp+GcSkfOJ6ob7ZGHB1TBJjRVAqZlmGnzi3d+ wz9Q== X-Forwarded-Encrypted: i=1; AJvYcCWT6yiqEfLbQJWdp4HuY9C28VDsCRRmbTuO3xAU3XQpDX3s7m4Ujjo23K7514RQULih5agdslk3n5GkKs1iqXRos/GYHga2uetUV/Y= X-Gm-Message-State: AOJu0YyP7a/qXQyIwvZpgfFpMCw4LgOO81HaTLb9pRFRIg16SlngUhZE lq3oMVpto5gdUnR1Lwn0sfqjLzB+7s2ryveQMhU8P9i2K13Dmkzjr9GXxaNkrJk= X-Google-Smtp-Source: AGHT+IFgr4iSfGSF5IPV3zZl5qFPlqcnaulUtE1TfAC51U6Q4NBcINjOTwVkZv2IxHULMCAp2GZWSA== X-Received: by 2002:a17:902:eccc:b0:1f7:1a37:d0b5 with SMTP id d9443c01a7336-1f862c30f6amr26779945ad.4.1718368424251; Fri, 14 Jun 2024 05:33:44 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e55c3bsm31084685ad.57.2024.06.14.05.33.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 05:33:43 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 06:33:41 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move integrity settings to queue_limits v3 To: Christoph Hellwig , "Martin K. Petersen" Cc: Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org References: <20240613084839.1044015-1-hch@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240613084839.1044015-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/13/24 2:48 AM, Christoph Hellwig wrote: > Hi Jens, hi Martin, > > this series converts the blk-integrity settings to sit in the queue > limits and be updated through the atomic queue limits API. > > I've mostly tested this with nvme, scsi is only covered by simple > scsi_debug based tests. > > For MD I found an pre-existing error handling bug when combining PI > capable devices with not PI capable devices. The fix was posted here > (and is included in the git branch below): > > https://lore.kernel.org/linux-raid/20240604172607.3185916-1-hch@lst.de/ > > For dm-integrity my testing showed that even the baseline fails to create > the luks-based dm-crypto with dm-integrity backing for the authentication > data. As the failure is non-fatal I've not addressed it here. > > Note that the support for native metadata in dm-crypt by Mikulas will > need a rebase on top of this, but as it already requires another > block layer patch and the changes in this series will simplify it a bit > I hope that is ok. > > The series is based on top of my previously sent "convert the SCSI ULDs > to the atomic queue limits API v2" API. I was going to queue this up, but: drivers/scsi/sd.c: In function ‘sd_revalidate_disk’: drivers/scsi/sd.c:3658:45: error: ‘lim’ undeclared (first use in this function) 3658 | sd_config_protection(sdkp, &lim); | ^~~ drivers/scsi/sd.c:3658:45: note: each undeclared identifier is reported only once for each function it appears in -- Jens Axboe