From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH 1/1] bcache: remove dupplicated declaration from btree.h
Date: Tue, 24 Mar 2020 20:42:57 -0600 [thread overview]
Message-ID: <f165ad0c-c78c-d738-269b-8a6433b0bbac@kernel.dk> (raw)
In-Reply-To: <364bfce6-7bbc-6bfa-fcc1-3dbb97c1acec@suse.de>
On 3/24/20 8:32 PM, Coly Li wrote:
> On 2020/3/25 9:57 上午, Jens Axboe wrote:
>> On 3/24/20 7:30 PM, Coly Li wrote:
>>> Commit ab544165dc2d ("bcache: move macro btree() and btree_root()
>>> into btree.h") makes two duplicated declaration into btree.h,
>>> typedef int (btree_map_keys_fn)();
>>> int bch_btree_map_keys();
>>>
>>> The kbuild test robot <lkp@intel.com> detects and reports this
>>> problem and this patch fixes it by removing the duplicated ones.
>>>
>>> Fixes: ab544165dc2d ("bcache: move macro btree() and btree_root() into btree.h")
>>
>> Applied, but I fixed up the commit sha, not sure where yours is from?
>>
>
> I should use the sha from your tree, not mine. I just realize with your
> SOB the sha number should change. Sorry for the inconvenience, and I
> will notice such condition next time.
>
> BTW, you still find such issue by your own eyes, without any extra tool?
Manual inspection, to try and avoid cases where the sha is either too
short, or just plain wrong.
--
Jens Axboe
prev parent reply other threads:[~2020-03-25 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 1:30 [PATCH 0/1] bcache: 2nd wave patch for Linux v5.7-rc1 Coly Li
2020-03-25 1:30 ` [PATCH 1/1] bcache: remove dupplicated declaration from btree.h Coly Li
2020-03-25 1:57 ` Jens Axboe
2020-03-25 2:32 ` Coly Li
2020-03-25 2:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f165ad0c-c78c-d738-269b-8a6433b0bbac@kernel.dk \
--to=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).