From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F53C433EF for ; Thu, 17 Mar 2022 11:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232575AbiCQLXZ (ORCPT ); Thu, 17 Mar 2022 07:23:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231824AbiCQLXZ (ORCPT ); Thu, 17 Mar 2022 07:23:25 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D8C31E31AD; Thu, 17 Mar 2022 04:22:08 -0700 (PDT) Received: from kwepemi500014.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KK4Sk0txBzfYqQ; Thu, 17 Mar 2022 19:20:38 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by kwepemi500014.china.huawei.com (7.221.188.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 19:22:06 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 17 Mar 2022 19:22:05 +0800 Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk() To: Ming Lei CC: Christoph Hellwig , , , , , , References: <20220210115637.1074927-1-yukuai3@huawei.com> <836f0686-4ac8-327d-2bab-64a762ea8673@huawei.com> From: "yukuai (C)" Message-ID: Date: Thu, 17 Mar 2022 19:22:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org 在 2022/03/02 8:51, Ming Lei 写道: > On Tue, Mar 01, 2022 at 09:54:28PM +0800, yukuai (C) wrote: >> 在 2022/03/01 18:29, Ming Lei 写道: >>> On Mon, Feb 28, 2022 at 01:40:53AM -0800, Christoph Hellwig wrote: >>>> On Mon, Feb 28, 2022 at 02:11:30PM +0800, Ming Lei wrote: >>>>>> FYI, this crashed left rigt and center when running xfstests with >>>>>> traces pointing to throtl_pending_timer_fn. >>>>> >>>>> Can you share the exact xfstests test(fs, test)? Or panic log? >>>>> >>>>> I can't reproduce it when running './check -g auto' on XFS, meantime >>>>> tracking throtl_pending_timer_fn(). >>>> >>>> From a quick run using f2fs: >>>> >>>> generic/081 files ... [ 316.487861] run fstests generic/081 at 2022-02-28 09:38:40 >>> >>> Thanks for providing the reproducer. >>> >>> The reason is that the pending timer is deleted in blkg's release >>> handler, so the timer can still be live after request queue is released. >>> >>> The patch of 'block: cancel all throttled bios in del_gendisk()' should just >>> make it easier to trigger. >>> >>> After patch of "block: move blkcg initialization/destroy into disk allocation/ >>> release handler" lands, the issue can be fixed easily by: Hi, Ming Now that the above patch is landed in linux-next, do you intend to fix the above problem? Or I can take over if you don't mind. Thanks, Kuai