From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH blktests 5/9] scsi/004: allow to run with built-in scsi_debug
Date: Tue, 18 Apr 2023 20:18:34 +0000 [thread overview]
Message-ID: <f4997765-6ea5-52ad-e329-73b9e5eedde5@nvidia.com> (raw)
In-Reply-To: <20230417125913.458726-1-shinichiro@fastmail.com>
On 4/17/23 05:59, Shin'ichiro Kawasaki wrote:
> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>
> To allow the test case run with build-in scsi_debug, replace
> '_have_module scsi_debug' with _have_scsi_debug, and replace
> _init_scsi_debug with _configure_scsi_debug.
>
> Also, save and restore the values of scsi_debug parameters 'opts' and
> 'ndelay'. The test case modifies the parameters and do not restore their
> original values. It is fine when scsi_debug is loadable since scsi_debug
> is unloaded after the test case run. However, when scsi_debug is built-
> in, the modified parameters may affect following test cases. To avoid
> potential impact on following test cases, save original values of the
> parameters and restore them at the end of the test case.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>
Perhaps we should look into a helper to record other default
parameters before the testcase and restore it after when
it is built in ?
Irrespective of that, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-04-18 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 12:59 [PATCH blktests 5/9] scsi/004: allow to run with built-in scsi_debug Shin'ichiro Kawasaki
2023-04-17 12:59 ` [PATCH blktests 6/9] scsi/005: " Shin'ichiro Kawasaki
2023-04-18 20:19 ` Chaitanya Kulkarni
2023-04-17 12:59 ` [PATCH blktests 7/9] block/001: allow to run with built-in scsi_debug and sd_mod Shin'ichiro Kawasaki
2023-04-18 20:20 ` Chaitanya Kulkarni
2023-04-17 12:59 ` [PATCH blktests 8/9] block/002: allow to run with built-in scsi_debug Shin'ichiro Kawasaki
2023-04-18 20:20 ` Chaitanya Kulkarni
2023-04-17 12:59 ` [PATCH blktests 9/9] block/027: " Shin'ichiro Kawasaki
2023-04-18 20:21 ` Chaitanya Kulkarni
2023-04-18 20:18 ` Chaitanya Kulkarni [this message]
2023-04-21 11:13 ` [PATCH blktests 5/9] scsi/004: " Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4997765-6ea5-52ad-e329-73b9e5eedde5@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).