From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Treat REQ_FUA and REQ_PREFLUSH as synchronous
Date: Tue, 2 May 2017 08:49:14 -0600 [thread overview]
Message-ID: <f4bedc20-7b27-bfa9-76c6-c34c8c3e816b@kernel.dk> (raw)
In-Reply-To: <20170502144505.GA29623@infradead.org>
On 05/02/2017 08:45 AM, Christoph Hellwig wrote:
> On Tue, May 02, 2017 at 12:21:23PM +0200, Jan Kara wrote:
>> it makes sense to treat REQ_FUA and REQ_PREFLUSH ops as synchronous in
>> op_is_sync() since callers cannot rely on this anyway... Thoughts?
>
> I'm fine with treating them as sync.
Yes me too. It makes sense to do so implicitly, and it avoids having
to go and add REQ_SYNC in a bunch of places. That will also be more
error proof in the future.
Jan, will you send a patch for that?
--
Jens Axboe
next prev parent reply other threads:[~2017-05-02 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 10:21 Treat REQ_FUA and REQ_PREFLUSH as synchronous Jan Kara
2017-05-02 14:45 ` Christoph Hellwig
2017-05-02 14:49 ` Jens Axboe [this message]
2017-05-02 15:15 ` Jan Kara
2017-05-02 15:18 ` Christoph Hellwig
2017-05-02 16:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4bedc20-7b27-bfa9-76c6-c34c8c3e816b@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).