* [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION()
@ 2024-04-29 9:12 Zhu Yanjun
2024-04-29 19:45 ` Chaitanya Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Zhu Yanjun @ 2024-04-29 9:12 UTC (permalink / raw)
To: axboe, linux-block; +Cc: Zhu Yanjun
No functional changes intended.
Fixes: f2298c0403b0 ("null_blk: multi queue aware block test driver")
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/block/null_blk/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index eed63f95e89d..aa084ae75e53 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -2121,4 +2121,5 @@ module_init(null_init);
module_exit(null_exit);
MODULE_AUTHOR("Jens Axboe <axboe@kernel.dk>");
+MODULE_DESCRIPTION("Null test block driver");
MODULE_LICENSE("GPL");
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION()
2024-04-29 9:12 [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION() Zhu Yanjun
@ 2024-04-29 19:45 ` Chaitanya Kulkarni
2024-04-29 19:48 ` Zhu Yanjun
0 siblings, 1 reply; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-04-29 19:45 UTC (permalink / raw)
To: Zhu Yanjun, axboe@kernel.dk, linux-block@vger.kernel.org
On 4/29/24 02:12, Zhu Yanjun wrote:
> No functional changes intended.
>
> Fixes: f2298c0403b0 ("null_blk: multi queue aware block test driver")
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/block/null_blk/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index eed63f95e89d..aa084ae75e53 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -2121,4 +2121,5 @@ module_init(null_init);
> module_exit(null_exit);
>
> MODULE_AUTHOR("Jens Axboe <axboe@kernel.dk>");
> +MODULE_DESCRIPTION("Null test block driver");
why not :-
"multi queue aware block test driver"
> MODULE_LICENSE("GPL");
irrespective of that, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION()
2024-04-29 19:45 ` Chaitanya Kulkarni
@ 2024-04-29 19:48 ` Zhu Yanjun
0 siblings, 0 replies; 3+ messages in thread
From: Zhu Yanjun @ 2024-04-29 19:48 UTC (permalink / raw)
To: Chaitanya Kulkarni, axboe@kernel.dk, linux-block@vger.kernel.org
在 2024/4/29 21:45, Chaitanya Kulkarni 写道:
> On 4/29/24 02:12, Zhu Yanjun wrote:
>> No functional changes intended.
>>
>> Fixes: f2298c0403b0 ("null_blk: multi queue aware block test driver")
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
>> ---
>> drivers/block/null_blk/main.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
>> index eed63f95e89d..aa084ae75e53 100644
>> --- a/drivers/block/null_blk/main.c
>> +++ b/drivers/block/null_blk/main.c
>> @@ -2121,4 +2121,5 @@ module_init(null_init);
>> module_exit(null_exit);
>>
>> MODULE_AUTHOR("Jens Axboe <axboe@kernel.dk>");
>> +MODULE_DESCRIPTION("Null test block driver");
> why not :-
>
> "multi queue aware block test driver"
Thanks a lot. The above is from Kconfig.
Your suggestion is more fascinating. If everyone agrees, I will use yours.
>
>> MODULE_LICENSE("GPL");
> irrespective of that, looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Thanks
Zhu Yanjun
>
> -ck
>
>
--
I only represent myself.
Zhu Yanjun or Yanjun.Zhu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-29 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 9:12 [PATCH 1/1] null_blk: Fix the WARNING: modpost: missing MODULE_DESCRIPTION() Zhu Yanjun
2024-04-29 19:45 ` Chaitanya Kulkarni
2024-04-29 19:48 ` Zhu Yanjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox