From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC12C05027 for ; Thu, 26 Jan 2023 09:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236973AbjAZJdC (ORCPT ); Thu, 26 Jan 2023 04:33:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236965AbjAZJc7 (ORCPT ); Thu, 26 Jan 2023 04:32:59 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00F8D21A2B for ; Thu, 26 Jan 2023 01:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674725530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwdoVdvZ1FxySXHtS/y2n7jjp83gxbEJIMQ/l72KDiI=; b=iVtlOVJHJ+phV5pf989dn5C3e5xfbXeZFsoOIBVNwh7shkOKBypNI2RnvRNiSFqBlE4qDy bwZX+Qt9+H3PIjsrYIlUIJMMVFo0Y1oUrjrOpndBA8Z+Ehhz/1CvYn6aMFJmg2AITnLiWT m1GHSwOHsrnUgZ8SkINGlZNjSeKyDf4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-yFLY026bNt-dqrXsnJdWQA-1; Thu, 26 Jan 2023 04:32:08 -0500 X-MC-Unique: yFLY026bNt-dqrXsnJdWQA-1 Received: by mail-wr1-f72.google.com with SMTP id t20-20020adfba54000000b002be0eb97f4fso160682wrg.8 for ; Thu, 26 Jan 2023 01:32:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wwdoVdvZ1FxySXHtS/y2n7jjp83gxbEJIMQ/l72KDiI=; b=0IWm3VcM/gWyT+RTkJEqv4Qxu+nQT2i6TydSJBlU0XFBH0NxQLK/fz4K+dng71SQAa SKCQM2Z7GZn/ihOTl+Al87P/wzeRWAIISZa85afoy20D9kIXIHCyfN1Y+VkrLSloxF7v hiMtkh2RacXel7VqmBoWFPvsqCBnwugMIP/EL1fhtNL45Cl9ZjSDf4UfTiUfH5AH5zjk ofYvxZvpXDimmD9xfqTVcI8dPymDIY1aMflN014f5t53KNyE6VyMyc6NgtvNo9C6+ziU 0c7XOa4bRflZQ3ORCwFLpYjvAAqnO6PtFtDA3lziubuHFwlJm7Rcql21tk1KAB9sXcv3 L7jw== X-Gm-Message-State: AFqh2koNLLoTD0iXfW7E5ZrwAQvZNejvvrPXTkO2MAtwhtwK3FQkrkvB gNQCIdp6gg/AguZCMY4IacdDt+N27ZElyPS0IgEFik/180tz7h3aG39wvnDGeb1fFnPhOgFpGBu 4/kk5AxpufiWEQeVRtbcz5Fk= X-Received: by 2002:a5d:4350:0:b0:2be:5366:8cdf with SMTP id u16-20020a5d4350000000b002be53668cdfmr19139274wrr.20.1674725527625; Thu, 26 Jan 2023 01:32:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvuEnatbeSNJHS0IKM41wypa1ffgMRJyS1j0d/4+OLyN2ZtqLoQlAGksy5c3U4wNl1YCZjPqQ== X-Received: by 2002:a5d:4350:0:b0:2be:5366:8cdf with SMTP id u16-20020a5d4350000000b002be53668cdfmr19139245wrr.20.1674725527332; Thu, 26 Jan 2023 01:32:07 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id l13-20020adff48d000000b002366e3f1497sm784664wro.6.2023.01.26.01.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:32:06 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:32:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Content-Language: en-US To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230125210657.2335748-6-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 25.01.23 22:06, David Howells wrote: > From: Christoph Hellwig > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > meaning is only set when a page reference has been acquired that needs to > be released by bio_release_pages(). > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > Reviewed-by: John Hubbard > cc: Al Viro > cc: Jens Axboe > cc: Jan Kara > cc: Matthew Wilcox > cc: Logan Gunthorpe > cc: linux-block@vger.kernel.org > --- Oh, and I agree with a previous comment that this patch should also hold a Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as the author via "From:". I remember stumbling over that in submitting-patches.rst ... -- Thanks, David / dhildenb