Linux block layer
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	linux-block <linux-block@vger.kernel.org>,
	"yukuai (C)" <yukuai3@huawei.com>,
	"zhangyi (F)" <yi.zhang@huawei.com>
Subject: Re: wbt_lat_usec still set despite wbt disabled by BFQ
Date: Tue, 13 Sep 2022 16:12:13 +0200	[thread overview]
Message-ID: <f731dab6-7f55-42d1-53fd-b656d75e5620@applied-asynchrony.com> (raw)
In-Reply-To: <17e0e889-e848-0bd3-3203-cb4e9b801462@huaweicloud.com>

On 2022-09-13 15:39, Yu Kuai wrote:
> Hi, Holger
> 
> 在 2022/08/18 1:12, Holger Hoffstätte 写道:
>>
>> I just noticed that my device configured with BFQ still shows wbt_lat_usec
>> as configured, despite the fact that BFQ disables WBT in bfq_init_queue [1]:
>>
>> $cat /sys/block/sdc/queue/scheduler
>> mq-deadline [bfq] none
>> $cat /sys/block/sdc/queue/wbt_lat_usec
>> 75000
>>
>> Is this supposed to be 0 (since it's disabled) or is sysfs confused?
>>
>> Thanks,
>> Holger
> 
> I'm reviewing wbt codes recently, and I found that this problem will
> happen if the default elevator is bfq. I'll try to fix this, do you mind
> if I add reported-by tag?

Do not mind at all - thank you for looking into it!
Let me know if I can test a patch or help in some other way.

Btw not sure what "default scheduler" means here, I set my schedulers via
udev rules. In this case:

ACTION=="add", KERNEL=="sd[a-z]", ATTR{queue/rotational}=="1", ATTR{queue/scheduler}="bfq"

cheers
Holger

  reply	other threads:[~2022-09-13 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 17:12 wbt_lat_usec still set despite wbt disabled by BFQ Holger Hoffstätte
2022-09-13 13:39 ` Yu Kuai
2022-09-13 14:12   ` Holger Hoffstätte [this message]
2022-09-13 14:20     ` Yu Kuai
2022-09-13 16:13       ` Holger Hoffstätte
2022-09-14  1:35         ` Yu Kuai
2022-09-14  6:05           ` Holger Hoffstätte
2022-09-14  9:23             ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f731dab6-7f55-42d1-53fd-b656d75e5620@applied-asynchrony.com \
    --to=holger@applied-asynchrony.com \
    --cc=linux-block@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox