From: Hannes Reinecke <hare@suse.de>
To: Niklas Cassel <nks@flawful.org>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-block@vger.kernel.org,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH v5 10/19] scsi: sd: set read/write commands CDL index
Date: Tue, 4 Apr 2023 20:50:08 +0200 [thread overview]
Message-ID: <f73713fd-a67b-e5c1-646f-18b51d5f06de@suse.de> (raw)
In-Reply-To: <20230404182428.715140-11-nks@flawful.org>
On 4/4/23 20:24, Niklas Cassel wrote:
> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> Introduce the command duration limits helper function sd_cdl_dld() to
> set the DLD bits of READ/WRITE 16 and READ/WRITE 32 commands to
> indicate to the device the command duration limit descriptor to apply
> to the commands.
>
> When command duration limits are enabled, sd_cdl_dld() obtains the
> index of the descriptor to apply to the command using the hints field of
> the request IO priority value (hints IOPRIO_HINT_DEV_DURATION_LIMIT_1 to
> IOPRIO_HINT_DEV_DURATION_LIMIT_7).
>
> If command duration limits is disabled (which is the default), the limit
> index "0" is always used to indicate "no limit" for a command.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Co-developed-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
> drivers/scsi/sd.c | 40 ++++++++++++++++++++++++++++++++++------
> 1 file changed, 34 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2023-04-04 18:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 18:24 [PATCH v5 00/19] Add Command Duration Limits support Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 01/19] ioprio: cleanup interface definition Niklas Cassel
2023-04-04 18:39 ` Hannes Reinecke
2023-04-04 18:24 ` [PATCH v5 02/19] block: introduce ioprio hints Niklas Cassel
2023-04-04 18:45 ` Hannes Reinecke
2023-04-04 18:24 ` [PATCH v5 03/19] block: introduce BLK_STS_DURATION_LIMIT Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 04/19] scsi: core: allow libata to complete successful commands via EH Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 05/19] scsi: rename and move get_scsi_ml_byte() Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 06/19] scsi: support retrieving sub-pages of mode pages Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 07/19] scsi: support service action in scsi_report_opcode() Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 08/19] scsi: detect support for command duration limits Niklas Cassel
2023-04-04 18:48 ` Hannes Reinecke
2023-04-04 23:27 ` Damien Le Moal
2023-04-05 6:26 ` Hannes Reinecke
2023-04-04 18:24 ` [PATCH v5 09/19] scsi: allow enabling and disabling " Niklas Cassel
2023-04-04 19:28 ` Igor Pylypiv
2023-04-04 23:18 ` Damien Le Moal
2023-04-04 18:24 ` [PATCH v5 10/19] scsi: sd: set read/write commands CDL index Niklas Cassel
2023-04-04 18:50 ` Hannes Reinecke [this message]
2023-04-04 18:24 ` [PATCH v5 11/19] scsi: sd: handle read/write CDL timeout failures Niklas Cassel
2023-04-04 18:56 ` Hannes Reinecke
2023-04-04 18:24 ` [PATCH v5 12/19] ata: libata-scsi: remove unnecessary !cmd checks Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 13/19] ata: libata: change ata_eh_request_sense() to not set CHECK_CONDITION Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 14/19] ata: libata: detect support for command duration limits Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 15/19] ata: libata-scsi: handle CDL bits in ata_scsiop_maint_in() Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 16/19] ata: libata-scsi: add support for CDL pages mode sense Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 17/19] ata: libata: add ATA feature control sub-page translation Niklas Cassel
2023-04-04 18:24 ` [PATCH v5 18/19] ata: libata: set read/write commands CDL index Niklas Cassel
2023-04-05 18:26 ` Igor Pylypiv
2023-04-05 22:29 ` Damien Le Moal
2023-04-04 18:24 ` [PATCH v5 19/19] ata: libata: handle completion of CDL commands using policy 0xD Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73713fd-a67b-e5c1-646f-18b51d5f06de@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=niklas.cassel@wdc.com \
--cc=nks@flawful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).