From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: ensure that struct blk_mq_alloc_data is fully initialized
Date: Tue, 15 Apr 2025 15:39:46 +0000 [thread overview]
Message-ID: <f76042e9-6855-4134-bc45-a38c5102b33d@nvidia.com> (raw)
In-Reply-To: <1720cf81-6170-4cac-abf3-e19a4493653b@kernel.dk>
On 4/15/25 07:51, Jens Axboe wrote:
> On x86, rep stos will be emitted to clear the the blk_mq_alloc_data
> struct, as not all members are being initialied. Depending on the
> type of CPU, this is a noticeable slowdown compared to just ensuring
> that the struct is fully initialized when setup.
>
> Signed-off-by: Jens Axboe<axboe@kernel.dk>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-04-15 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 14:51 [PATCH] block: ensure that struct blk_mq_alloc_data is fully initialized Jens Axboe
2025-04-15 15:39 ` Chaitanya Kulkarni [this message]
2025-04-15 15:50 ` Bart Van Assche
2025-04-15 15:59 ` Jens Axboe
2025-04-15 16:13 ` Bart Van Assche
2025-04-15 16:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f76042e9-6855-4134-bc45-a38c5102b33d@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox