From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Min Li <min15.li@samsung.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"willy@infradead.org" <willy@infradead.org>,
"hch@lst.de" <hch@lst.de>,
"dlemoal@kernel.org" <dlemoal@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] block: add check that partition length needs to be aligned with block size
Date: Tue, 27 Jun 2023 04:19:41 +0000 [thread overview]
Message-ID: <f7a3329f-b66e-1de0-a455-faa29eb214c5@nvidia.com> (raw)
In-Reply-To: <20230627110918.7608-1-min15.li@samsung.com>
On 6/27/2023 4:09 AM, Min Li wrote:
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
>
> Signed-off-by: Min Li <min15.li@samsung.com>
>
> ---
> Changes from v1:
>
> - Add a space after /* and before */.
> - Move length alignment check before the "start = p.start >> SECTOR_SHIFT"
> - Move check for p.start being aligned together with this length alignment check.
> ---
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-06-27 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230627031105epcas5p3010432ebd447ad865c3ddd986b3ffee0@epcas5p3.samsung.com>
2023-06-27 11:09 ` [PATCH v2] block: add check that partition length needs to be aligned with block size Min Li
2023-06-27 4:19 ` Chaitanya Kulkarni [this message]
2023-06-27 4:39 ` Damien Le Moal
2023-06-27 4:59 ` Christoph Hellwig
2023-06-27 6:18 ` Greg KH
2023-06-27 6:21 ` Christoph Hellwig
2023-06-27 8:13 ` Pankaj Raghav
2023-06-27 17:53 ` Matthew Wilcox
2023-06-27 4:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7a3329f-b66e-1de0-a455-faa29eb214c5@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min15.li@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox