From: Jens Axboe <axboe@kernel.dk>
To: yukuai@fnnas.com, Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org
Cc: hch@lst.de, ming.lei@redhat.com, yi.zhang@redhat.com,
shinichiro.kawasaki@wdc.com, gjoyce@ibm.com
Subject: Re: [PATCHv2] block: break pcpu_alloc_mutex dependency on freeze_lock
Date: Mon, 2 Mar 2026 09:24:21 -0700 [thread overview]
Message-ID: <f83f7246-dad7-478e-a3b9-491a54e5443b@kernel.dk> (raw)
In-Reply-To: <8eaab53b-6525-4a9f-9a4b-94ce7e7fc09f@fnnas.com>
On 3/1/26 10:11 PM, Yu Kuai wrote:
>> for (i = set->nr_hw_queues; i < new_nr_hw_queues; i++) {
>> - if (!__blk_mq_alloc_map_and_rqs(set, i)) {
>> - while (--i >= set->nr_hw_queues)
>> - __blk_mq_free_map_and_rqs(set, i);
>> - return -ENOMEM;
>> + if (blk_mq_is_shared_tags(set->flags))
>> + new_tags[i] = set->shared_tags;
>
> I think usually we'll keep the braces for if branch.
>
> Otherwise feel free to add:
>
> Reviewed-by: Yu Kuai <yukuai@fnnas.com>
Indeed, I fixed up the style issue.
--
Jens Axboe
next prev parent reply other threads:[~2026-03-02 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 12:59 [PATCHv2] block: break pcpu_alloc_mutex dependency on freeze_lock Nilay Shroff
2026-03-02 5:11 ` Yu Kuai
2026-03-02 16:24 ` Jens Axboe [this message]
2026-03-02 7:42 ` Yi Zhang
2026-03-02 14:05 ` Ming Lei
2026-03-02 16:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83f7246-dad7-478e-a3b9-491a54e5443b@kernel.dk \
--to=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@redhat.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox