From: Jens Axboe <axboe@kernel.dk>
To: Yi Zhang <yi.zhang@redhat.com>
Cc: Ming Lei <ming.lei@redhat.com>,
Steffen Maier <maier@linux.ibm.com>,
linux-block <linux-block@vger.kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [bug report] WARNING: CPU: 1 PID: 1386 at block/blk-mq-sched.c:432 blk_mq_sched_insert_request+0x54/0x178
Date: Wed, 3 Nov 2021 13:03:34 -0600 [thread overview]
Message-ID: <f95deb32-59a0-1fc1-b7b2-92583a5ef4de@kernel.dk> (raw)
In-Reply-To: <CAHj4cs-pTYoksSQDjfFpK13Xtg0jB6EOvhfOZu5cDHowZa=ueg@mail.gmail.com>
On 11/2/21 10:00 PM, Yi Zhang wrote:
>>>
>>> Hello Jens,
>>>
>>> I guess the issue could be the following code run without grabbing
>>> ->q_usage_counter from blk_mq_alloc_request() and blk_mq_alloc_request_hctx().
>>>
>>> .rq_flags = q->elevator ? RQF_ELV : 0,
>>>
>>> then elevator is switched to real one from none, and check on q->elevator
>>> becomes not consistent.
>>
>> Indeed, that’s where I was going with this. I have a patch, testing it locally but it’s getting late. Will send it out tomorrow. The nice benefit is that it allows dropping the weird ref get on plug flush, and batches getting the refs as well.
>>
>
> Hi Jens
> Here is the log in case you still need it. :)
Can you retry with the updated for-next pulled into -git?
--
Jens Axboe
next prev parent reply other threads:[~2021-11-03 19:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 6:42 [bug report] WARNING: CPU: 1 PID: 1386 at block/blk-mq-sched.c:432 blk_mq_sched_insert_request+0x54/0x178 Yi Zhang
2021-11-02 19:00 ` Steffen Maier
2021-11-02 19:02 ` Jens Axboe
2021-11-02 20:03 ` Jens Axboe
2021-11-03 2:21 ` Yi Zhang
2021-11-03 3:21 ` Jens Axboe
2021-11-03 3:28 ` Daejun Park
2021-11-03 3:51 ` Ming Lei
2021-11-03 3:54 ` Jens Axboe
2021-11-03 4:00 ` Yi Zhang
2021-11-03 19:03 ` Jens Axboe [this message]
2021-11-05 11:13 ` Yi Zhang
2021-11-03 11:59 ` Jens Axboe
2021-11-03 13:59 ` Yi Zhang
2021-11-03 14:26 ` Jens Axboe
2021-11-03 14:57 ` Ming Lei
2021-11-03 15:03 ` Jens Axboe
2021-11-03 15:09 ` Ming Lei
2021-11-03 15:12 ` Jens Axboe
2021-11-03 15:10 ` Jens Axboe
2021-11-03 15:16 ` Ming Lei
2021-11-03 15:41 ` Jens Axboe
2021-11-03 15:49 ` Jens Axboe
2021-11-03 16:09 ` Ming Lei
2021-11-03 16:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f95deb32-59a0-1fc1-b7b2-92583a5ef4de@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox