From: Milan Broz <gmazyland@gmail.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
axboe@kernel.dk, jack@suse.cz
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: remember whether sysfs_create_group() succeeded
Date: Tue, 8 May 2018 11:02:43 +0200 [thread overview]
Message-ID: <fa79ae8f-b135-eaf2-0dfd-03a14e205a7a@gmail.com> (raw)
In-Reply-To: <201805052049.IDD12470.OLHVOMFFOQtSFJ@I-love.SAKURA.ne.jp>
On 05/05/2018 01:49 PM, Tetsuo Handa wrote:
> Milan Broz wrote:
>>> Do we want to abort LOOP_SET_FD request if sysfs_create_group() failed?
>>
>> I would prefer failure - there are several utilities that expects attributes in
>> sysfs to be valid (for example I print info from here in cryptsetup status
>> if the backing image is an image), so ignoring failure put the system
>> in inconsistent state.
>
> I see. But can we for now send v1 patch for 4.17 release (and postpone making
> LOOP_SET_FD request fail if sysfs_create_group() failed)? This bug has so far
> crashed syzbot tests for 6432 times in 190 days.
Jens already merged it in the block git. So syzbot should be more happy now :)
> We have a lot of bugs regarding loop module which prevent syzbot from
> finding other bugs. I want to immediately squash bugs in block/loop so that
> we can reduce false-positive hung task reports.
Sure, syzbot is definitely very useful idea, thanks!
Milan
next prev parent reply other threads:[~2018-05-08 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001a113ed2fa7bedfe055c8316a5@google.com>
[not found] ` <94eb2c030882b2b1b505610813df@google.com>
[not found] ` <55ff5960-eaab-5a36-5605-4e2230b77607@I-love.SAKURA.ne.jp>
[not found] ` <20180502142434.GA10928@kroah.com>
2018-05-04 11:47 ` [PATCH] loop: remember whether sysfs_create_group() succeeded Tetsuo Handa
2018-05-04 14:15 ` Jens Axboe
2018-05-04 14:27 ` Tetsuo Handa
2018-05-04 14:30 ` Jens Axboe
2018-05-04 14:40 ` Tetsuo Handa
2018-05-04 14:43 ` Jens Axboe
2018-05-04 16:14 ` [PATCH v2] " Tetsuo Handa
2018-05-04 16:27 ` Jens Axboe
2018-05-04 16:47 ` Tetsuo Handa
2018-05-05 10:46 ` [PATCH] " Milan Broz
2018-05-05 11:49 ` Tetsuo Handa
2018-05-08 9:02 ` Milan Broz [this message]
2018-05-09 12:31 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa79ae8f-b135-eaf2-0dfd-03a14e205a7a@gmail.com \
--to=gmazyland@gmail.com \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox