From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 701DDC4708D for ; Mon, 2 Jan 2023 17:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234767AbjABRfw (ORCPT ); Mon, 2 Jan 2023 12:35:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236026AbjABRfu (ORCPT ); Mon, 2 Jan 2023 12:35:50 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C72CE6 for ; Mon, 2 Jan 2023 09:35:48 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id q9so1710334pgq.5 for ; Mon, 02 Jan 2023 09:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0/FLi7onUW3nYVddnO6ufjs5aBaW8qFFiB26AInMK3E=; b=1Zl5X9eDu29gEyWJkUd3WN95PDZ7pmieuyZgog/h8fWIF89EVUeYQ2cj0BpAUjwJj4 om8QY+oFVhiRQLuAW1xun+3txUwxj4pZF1UwD0wcRI9j+gMFfNUwTK2VMzP6gpZBLpf3 gPi1yf4ppqhEPRZw9Knu9hLwtocxe88cQn0autD5oZZztvigxEpa3hdn9iUIRmJWrxYG Vxr6RJ+K8G6A6dBs/tPlZu7KCjNpjBIoB2JPaDvIdDTUf3TcuHJ29xAbHh8PQIwdXyIC LuGQA5b1QQHiB3E0Wd/hy+BlfwaeHkxAFE6lHIX7IGkcDpXpAFlKZgXXYw7DWWzqUl/m a1Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0/FLi7onUW3nYVddnO6ufjs5aBaW8qFFiB26AInMK3E=; b=n5fsJeBk68/ockqVONL0vj9sXteYAGjl2vG1eG1TmbgokjhlyXcbiP9mxlXtpCfMo9 QZ6BX35+o4j4b9eFrDTH5+IOJtXXskfgrjQgasGxlTKJCRww6WERUq9W3eoIgt+yBsGy XBvUSMYh+PIz4MhqfA3uQ8VGoDUnzZn3UVGJifVcB/iygaYpgyv57MyeGQSf+gsp/cde GnaIvlMlnKvvGZa6xP5D52WUaGSszEh2j2+GD/lzVCzuTQpAEY0a6VTMJmQltAPRRgoH s5PSIXNsDKODzysBKtRVVBVF8OK9mR4zWEC8YU0YOHW8vIy5ucnXNND4QPwfO9BUSv7d V/tQ== X-Gm-Message-State: AFqh2kqxeTG2L63S+YFvID5kuJpCcI6fxX5qHt9ysfXKXmBe2Vgf9/o6 t+u+WgeoOLJCX2cWAGiu5MRa90rwllHMyzTt X-Google-Smtp-Source: AMrXdXvBFYldhHt4VPdiHQAA4t8vs65eDOK8fDS7D3BhKPJNuRtli+f6wQT43IPHh2PFTy0dlu2Kug== X-Received: by 2002:a05:6a00:72b:b0:576:f200:e3eb with SMTP id 11-20020a056a00072b00b00576f200e3ebmr9900196pfm.0.1672680948192; Mon, 02 Jan 2023 09:35:48 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id a125-20020a624d83000000b005771475561bsm18771186pfb.163.2023.01.02.09.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 09:35:47 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 10:35:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6 1/7] block: add a sanity check for non-write flush/fua bios Content-Language: en-US To: Damien Le Moal , linux-ide@vger.kernel.org, linux-block@vger.kernel.org Cc: "Maciej S . Szmigiero" , Hannes Reinecke , Christoph Hellwig References: <20221108055544.1481583-1-damien.lemoal@opensource.wdc.com> <20221108055544.1481583-2-damien.lemoal@opensource.wdc.com> From: Jens Axboe In-Reply-To: <20221108055544.1481583-2-damien.lemoal@opensource.wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/7/22 10:55 PM, Damien Le Moal wrote: > From: Christoph Hellwig > > Check that the PREFUSH and FUA flags are only set on write bios, > given that the flush state machine expects that. > > Reported-by: Damien Le Moal > Signed-off-by: Christoph Hellwig > Signed-off-by: Damien Le Moal > Reviewed-by: Chaitanya Kulkarni > Reviewed-by: Hannes Reinecke Reviewed-by: Jens Axboe -- Jens Axboe