From: Jens Axboe <axboe@fb.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 0/7] blk-mq: fix queue quiescing
Date: Thu, 25 May 2017 11:31:30 -0600 [thread overview]
Message-ID: <fb4abb2d-d6b4-5f90-b348-ae7e347e8fc3@fb.com> (raw)
In-Reply-To: <1495733047.2615.1.camel@sandisk.com>
On 05/25/2017 11:24 AM, Bart Van Assche wrote:
> On Thu, 2017-05-25 at 17:09 +0800, Ming Lei wrote:
>> Another big issue is that 'srcu_struct' is very big, which shouldn't
>> be embedded into hctx, since we only have one real user of
>> BLK_MQ_F_BLOCKING.
>>
>> So I will fix that too.
>
> Hello Ming,
>
> Is something like the (untested) patch below perhaps what you had in mind?
>
> Subject: [PATCH] blk-mq: Reduce blk_mq_hw_ctx size
>
> Since the srcu structure is rather large (184 bytes on an x86-64
> system), only allocate it if needed.
On my normal laptop setup, it's actually 408 bytes (!!).
--
Jens Axboe
next prev parent reply other threads:[~2017-05-25 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 4:21 [PATCH 0/7] blk-mq: fix queue quiescing Ming Lei
2017-05-25 4:21 ` [PATCH 1/7] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-05-25 4:21 ` [PATCH 2/7] block: introduce flag of QUEUE_FLAG_QUIESCED Ming Lei
2017-05-25 4:21 ` [PATCH 3/7] dm: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-05-25 4:21 ` [PATCH 4/7] nvme: " Ming Lei
2017-05-25 4:21 ` [PATCH 5/7] scsi: " Ming Lei
2017-05-25 4:21 ` [PATCH 6/7] blk-mq: quiesce queue via percpu_ref Ming Lei
2017-05-25 4:21 ` [PATCH 7/7] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-05-25 5:24 ` [PATCH 0/7] blk-mq: fix queue quiescing Bart Van Assche
2017-05-25 9:09 ` Ming Lei
2017-05-25 17:24 ` Bart Van Assche
2017-05-25 17:31 ` Jens Axboe [this message]
2017-05-25 17:42 ` Jens Axboe
2017-05-25 17:59 ` Bart Van Assche
2017-05-26 0:44 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4abb2d-d6b4-5f90-b348-ae7e347e8fc3@fb.com \
--to=axboe@fb.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox