* [PATCH] skd: Use kmem_cache_free
@ 2017-10-08 21:30 Himanshu Jha
2017-10-09 14:31 ` Jens Axboe
2017-10-09 17:33 ` Bart Van Assche
0 siblings, 2 replies; 3+ messages in thread
From: Himanshu Jha @ 2017-10-08 21:30 UTC (permalink / raw)
To: bart.vanassche; +Cc: linux-block, linux-kernel, Himanshu Jha
Use kmem_cache_free instead of kfree for freeing the memory previously
allocated with kmem_cache_zalloc/kmem_cache_alloc/kmem_cache_node.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/block/skd_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 7cedb42..64d0fc1 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2604,7 +2604,7 @@ static void *skd_alloc_dma(struct skd_device *skdev, struct kmem_cache *s,
return NULL;
*dma_handle = dma_map_single(dev, buf, s->size, dir);
if (dma_mapping_error(dev, *dma_handle)) {
- kfree(buf);
+ kmem_cache_free(s, buf);
buf = NULL;
}
return buf;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] skd: Use kmem_cache_free
2017-10-08 21:30 [PATCH] skd: Use kmem_cache_free Himanshu Jha
@ 2017-10-09 14:31 ` Jens Axboe
2017-10-09 17:33 ` Bart Van Assche
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2017-10-09 14:31 UTC (permalink / raw)
To: Himanshu Jha, bart.vanassche; +Cc: linux-block, linux-kernel
On 10/08/2017 03:30 PM, Himanshu Jha wrote:
> Use kmem_cache_free instead of kfree for freeing the memory previously
> allocated with kmem_cache_zalloc/kmem_cache_alloc/kmem_cache_node.
Good catch, I wonder how long that's been there... Applied for 4.14.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] skd: Use kmem_cache_free
2017-10-08 21:30 [PATCH] skd: Use kmem_cache_free Himanshu Jha
2017-10-09 14:31 ` Jens Axboe
@ 2017-10-09 17:33 ` Bart Van Assche
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2017-10-09 17:33 UTC (permalink / raw)
To: himanshujha199640@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
T24gTW9uLCAyMDE3LTEwLTA5IGF0IDAzOjAwICswNTMwLCBIaW1hbnNodSBKaGEgd3JvdGU6DQo+
IFVzZSBrbWVtX2NhY2hlX2ZyZWUgaW5zdGVhZCBvZiBrZnJlZSBmb3IgZnJlZWluZyB0aGUgbWVt
b3J5IHByZXZpb3VzbHkNCj4gYWxsb2NhdGVkIHdpdGgga21lbV9jYWNoZV96YWxsb2Mva21lbV9j
YWNoZV9hbGxvYy9rbWVtX2NhY2hlX25vZGUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBIaW1hbnNo
dSBKaGEgPGhpbWFuc2h1amhhMTk5NjQwQGdtYWlsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL2Js
b2NrL3NrZF9tYWluLmMgfCAyICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks
IDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Jsb2NrL3NrZF9tYWlu
LmMgYi9kcml2ZXJzL2Jsb2NrL3NrZF9tYWluLmMNCj4gaW5kZXggN2NlZGI0Mi4uNjRkMGZjMSAx
MDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ibG9jay9za2RfbWFpbi5jDQo+ICsrKyBiL2RyaXZlcnMv
YmxvY2svc2tkX21haW4uYw0KPiBAQCAtMjYwNCw3ICsyNjA0LDcgQEAgc3RhdGljIHZvaWQgKnNr
ZF9hbGxvY19kbWEoc3RydWN0IHNrZF9kZXZpY2UgKnNrZGV2LCBzdHJ1Y3Qga21lbV9jYWNoZSAq
cywNCj4gIAkJcmV0dXJuIE5VTEw7DQo+ICAJKmRtYV9oYW5kbGUgPSBkbWFfbWFwX3NpbmdsZShk
ZXYsIGJ1Ziwgcy0+c2l6ZSwgZGlyKTsNCj4gIAlpZiAoZG1hX21hcHBpbmdfZXJyb3IoZGV2LCAq
ZG1hX2hhbmRsZSkpIHsNCj4gLQkJa2ZyZWUoYnVmKTsNCj4gKwkJa21lbV9jYWNoZV9mcmVlKHMs
IGJ1Zik7DQo+ICAJCWJ1ZiA9IE5VTEw7DQo+ICAJfQ0KPiAgCXJldHVybiBidWY7DQoNClRoYW5r
cyBmb3IgdGhpcyBwYXRjaC4NCg0KUmV2aWV3ZWQtYnk6IEJhcnQgVmFuIEFzc2NoZSA8YmFydC52
YW5hc3NjaGVAd2RjLmNvbT4NCg0K
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-09 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-08 21:30 [PATCH] skd: Use kmem_cache_free Himanshu Jha
2017-10-09 14:31 ` Jens Axboe
2017-10-09 17:33 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox