Re: [PATCH blktests] loop: add test for creating/deleting file-ns

[Nilay Shroff <nilay@linux.ibm.com>]

On 6/19/24 13:20, Daniel Wagner wrote:
> On Mon, Jun 17, 2024 at 02:47:22PM GMT, Nilay Shroff wrote:
>> +test() {
>> +	echo "Running ${TEST_NAME}"
>> +
>> +	_setup_nvmet
>> +
>> +	local subsys="blktests-subsystem-1"
> 
> Use the default variables instead of duplicating them.
Yes that makes sense.
> 
>> +	local iterations="${NVME_NUM_ITER}"
>> +	local loop_dev
>> +	local port
>> +
>> +	truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path)"
>> +
>> +	loop_dev="$(losetup -f --show "$(_nvme_def_file_path)")"
>> +
>> +	port="$(_create_nvmet_port "${nvme_trtype}")"
>> +
>> +	_nvmet_target_setup --subsysnqn "${subsys}" --blkdev "${loop_dev}"
>> +
>> +	_nvme_connect_subsys --subsysnqn "${subsys}"
> 
> As far I can tell this could just be:
> 
> 	_nvmet_target_setup
> 
> 	_nvme_connect_subsys
> 
I updated test case using default subsysnqn and blkdev that works as expected. 
So yes I can use defaults for setting up and then connecting to nvme target.

I will update this in next patch.

Appreciate your review and suggestion... 

Thanks,
--Nilay