From: Jens Axboe <axboe@kernel.dk>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-block <linux-block@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Tim Waugh <tim@cyberelk.net>,
linux-parport@lists.infradead.org
Subject: Re: paride/pf.c: blk-mq use-after-free (kernel v5.0)
Date: Mon, 18 Mar 2019 08:08:06 -0600 [thread overview]
Message-ID: <fd6d1a5e-25d1-c05c-9b03-837300f8935f@kernel.dk> (raw)
In-Reply-To: <21e5a575-8f28-5a14-3916-ab41b4d37734@infradead.org>
On 3/16/19 5:48 PM, Randy Dunlap wrote:
> On 3/16/19 12:31 PM, Jens Axboe wrote:
>> On 3/15/19 6:32 PM, Randy Dunlap wrote:
>>> On 3/15/19 9:33 AM, Jens Axboe wrote:
>>>> On 3/14/19 5:49 PM, Randy Dunlap wrote:
>>>>> On 3/14/19 4:43 PM, Jens Axboe wrote:
>>>>>> On 3/13/19 5:09 PM, Randy Dunlap wrote:
>>>>>>> On 3/11/19 6:34 PM, Randy Dunlap wrote:
>>>>>>>> On 3/11/19 6:25 PM, Randy Dunlap wrote:
>>>>>>>>> [Has this already been addressed/fixed?]>>
>>>>>>>>
>>>>>>>> Same bug occurs with paride/pcd.c driver.
>>>>>>>
>>>>>>> This still happens (in blk-mq) in v5.0-11053-gebc551f2b8f9 of Mar. 12, 2019,
>>>>>>> around 4pm PT. [caused by paride: pf.c and pcd.c)
>>>>>>
>>>>>> I'll take a look at this, been busy with other stuff. How are you
>>>>>> reproducing this? I'm assuming you don't actually have any hardware :-)
>>>>>
>>>>> Right. I just load the module (pf or pcd), unload it, and
>>>>> then load it again.
>>>>
>>>> Does this work?
>>>>
>>>
>>> No. Just loading the pf module gives this:
>>
>> Missing clear of the queue. This one should be more complete.
>>
>> To be fair, this was utterly broken since forever. It's just now apparent
>> since we complain about it. But pf/pcd was one big leak fest.
>>
>
> OK, this one works for both pf and pcd.
> By "works" I mean that the driver init function runs and exits without
> causing a BUG or GP fault etc.
> Not that I have any such hardware.
>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks Randy, I'll get these queued up.
--
Jens Axboe
prev parent reply other threads:[~2019-03-18 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 1:25 paride/pf.c: blk-mq use-after-free (kernel v5.0) Randy Dunlap
2019-03-12 1:34 ` Randy Dunlap
2019-03-13 23:09 ` Randy Dunlap
2019-03-14 23:43 ` Jens Axboe
2019-03-14 23:49 ` Randy Dunlap
2019-03-15 16:33 ` Jens Axboe
2019-03-16 0:32 ` Randy Dunlap
2019-03-16 19:31 ` Jens Axboe
2019-03-16 23:48 ` Randy Dunlap
2019-03-18 14:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6d1a5e-25d1-c05c-9b03-837300f8935f@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox